linux-kernel - Re: [PATCH] Makefile: Yes. Finally remove '-Wdeclaration-after-statement'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200816175303.GB1236603@ZenIV.linux.org.uk>
Date:   Sun, 16 Aug 2020 18:53:03 +0100
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Michael Witten <mfwitten@...il.com>
Cc:     Masahiro Yamada <masahiroy@...nel.org>,
        Michal Marek <michal.lkml@...kovi.net>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Johannes Weiner <hannes@...xchg.org>,
        Sam Ravnborg <sam@...nborg.org>, linux-kernel@...r.kernel.org,
        linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] Makefile: Yes. Finally remove
 '-Wdeclaration-after-statement'

On Sun, Aug 16, 2020 at 04:35:00PM -0000, Michael Witten wrote:
> This is not just a matter of style; this is a matter of semantics,
> especially with regard to:
> 
>   * const Correctness.
>     A const-declared variable must be initialized when defined.
> 
>   * Conditional Compilation.
>     When there is complex interaction between compile-time
>     configuration options, it's essential to be able to
>     make declarations where needed; otherwise unnecessary
>     gymnastics are required to silence the compiler.
> 
> Gentleman... Just let people say exactly what they mean to say.
> 
> Requiring every declaration to be at the top of a block is an
> antiquated, vestigial naivete from a time when C was just a
> glorified abstraction over conventional patterns in assembly
> programming.
> 
> We are not just programming anymore. We are now encoding our
> very thoughts, and thus we need this expressiveness in order
> to capture those thoughts with sufficient clarity.

You obviously need every bit of help in that task, judging by the amount
of clarity (or thoughts, for that matter) visible in the spew above...

NAK.  And as for letting people say exactly what they mean to say...
I am tempted to take you on that invitation, but that would be cruel
to gregkh - he would have to reply to inevitable screeds about
CoC-violating postings on l-k.