lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 16 Aug 2020 21:04:17 +0200
From:   Sam Ravnborg <sam@...nborg.org>
To:     Guido Günther <agx@...xcpu.org>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Linus Walleij <linus.walleij@...aro.org>,
        Heiko Stuebner <heiko.stuebner@...obroma-systems.com>,
        Daniel Palmer <daniel@...f.com>,
        Lubomir Rintel <lkundrak@...sk>,
        Mark Brown <broonie@...nel.org>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        allen <allen.chen@....com.tw>,
        Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
        "David S. Miller" <davem@...emloft.net>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/3] drm/panel: Add panel driver for the Mantix
 MLAF057WE51-X DSI panel

On Sun, Aug 16, 2020 at 07:55:21PM +0200, Guido Günther wrote:
> Hi Sam,
> thanks for having a look!
> 
> On Sat, Aug 15, 2020 at 11:27:27PM +0200, Sam Ravnborg wrote:
> > Hi Guido.
> > 
> > On Sat, Aug 15, 2020 at 11:16:22PM +0200, Guido Günther wrote:
> > > The panel uses a Focaltech FT8006p, the touch part is handled by the
> > > already existing edt-ft5x06.
> > > 
> > > Signed-off-by: Guido Günther <agx@...xcpu.org>
> > 
> > Two small nits - otherwise looks good.
> > Reviewed-by: Sam Ravnborg <sam@...nborg.org>
> > 
> > I can fix while applying or you can send a new revision,
> > but I cannot apply until drm-misc-next have seen a backmerge
> > due to dev_err_probe() usage.
> 
> I'll send out a v3 with this fixed.
> 
> > Did you have commit rights yet?
> > If yes, then please apply yourself.
> 
> No commit rights here. So it would be great if you could apply the
> patches. Should I look for commit rights? I assume that means following
> 
>     https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html#drm-misc    
I recall we discussed this before for some other driver.
For a single panel it is not needed, but if you continue to be active
on other parts it makes sense.


I will apply v3 when drm-misc-next is backmeged unless you tell me
otherwise. And ping me if I forgets.

	Sam

Powered by blists - more mailing lists