linux-kernel - Re: [PATCH 1/3] usb: dwc3: of-simple: Add compatible for rk3328

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4482f04a-d75d-6ede-acae-eb3fc7364130@gmail.com>
Date:   Sun, 16 Aug 2020 21:23:36 +0200
From:   Johan Jonker <jbx6244@...il.com>
To:     Cameron Nemo <cnemo@...anota.com>,
        Devicetree <devicetree@...r.kernel.org>,
        Linux Arm Kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux Rockchip <linux-rockchip@...ts.infradead.org>,
        linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Cc:     robh+dt@...nel.org, Heiko <heiko@...ech.de>, balbi@...nel.org,
        gregkh@...uxfoundation.org
Subject: Re: [PATCH 1/3] usb: dwc3: of-simple: Add compatible for rk3328

Hi Cameron,

Use plain text mode for patches.

Before you introduce a new compatible string, your patch serie must
change the documents first in version 2.
See:

dwc3.txt
rockchip,dwc3.txt

(TODO but not now) Both documents are in need for a conversion to yaml.

Also sort nodes without reg alphabetically in rk3328-rock64.dts.

&u2phy {}
&uart2 {}
&usb20_otg {}
&usbdrd3 {}
&usbdrd_dwc3 {}
&usb_host0_ehci {}
&usb_host0_ohci {}

On 8/16/20 7:16 PM, Cameron Nemo wrote:
> Add a compatible to be hooked into by the Rockchip rk3328 device tree.
> 
> The rk3399 compatible cannot be reused because the rk3328 SoCs may
> require a specialized driver in the future, and old device trees must
> remain commpatible with newer kernels.
> 
> Signed-off-by: Cameron Nemo <cnemo@...anota.com>
> ---
> drivers/usb/dwc3/dwc3-of-simple.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
> index 7df115012935..54f38e434028 100644
> --- a/drivers/usb/dwc3/dwc3-of-simple.c
> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
> @@ -49,7 +49,8 @@ static int dwc3_of_simple_probe(struct platform_device *pdev)
> * Some controllers need to toggle the usb3-otg reset before trying to
> * initialize the PHY, otherwise the PHY times out.
> */
> -	if (of_device_is_compatible(np, "rockchip,rk3399-dwc3"))

> +	if (of_device_is_compatible(np, "rockchip,rk3399-dwc3") ||
> +	    of_device_is_compatible(np, "rockchip,rk3328-dwc3"))

sort alphabetically.

> simple->need_reset = true;
> 
> simple->resets = of_reset_control_array_get(np, false, true,
> @@ -171,6 +172,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = {
> };
> 
> static const struct of_device_id of_dwc3_simple_match[] = {
> +	{ .compatible = "rockchip,rk3328-dwc3" },
> { .compatible = "rockchip,rk3399-dwc3" },
> { .compatible = "xlnx,zynqmp-dwc3" },
> { .compatible = "cavium,octeon-7130-usb-uctl" },
> --
> 2.28.0
> 
> 
>