linux-kernel - Re: [PATCH] net: Fix potential wrong skb->protocol in skb_vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200816.153434.1972025769249325190.davem@davemloft.net>
Date:   Sun, 16 Aug 2020 15:34:34 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     linmiaohe@...wei.com
Cc:     kuba@...nel.org, pshelar@....org, fw@...len.de,
        martin.varghese@...ia.com, edumazet@...gle.com,
        dcaratti@...hat.com, steffen.klassert@...unet.com,
        pabeni@...hat.com, shmulik@...anetworks.com,
        kyk.segfault@...il.com, jiri@...lanox.com, vyasevic@...hat.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: Fix potential wrong skb->protocol in
 skb_vlan_untag()

From: Miaohe Lin <linmiaohe@...wei.com>
Date: Sat, 15 Aug 2020 04:44:31 -0400

> We may access the two bytes after vlan_hdr in vlan_set_encap_proto(). So
> we should pull VLAN_HLEN + sizeof(unsigned short) in skb_vlan_untag() or
> we may access the wrong data.
> 
> Fixes: 0d5501c1c828 ("net: Always untag vlan-tagged traffic on input.")
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>

Applied, thank you.