linux-kernel - Re: [PATCH] block: blk-mq.c: fix @at

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce836be4-a430-eec3-9268-a9ad080122e7@collabora.com>
Date:   Sun, 16 Aug 2020 19:50:14 -0300
From:   André Almeida <andrealmeid@...labora.com>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org
Subject: Re: [PATCH] block: blk-mq.c: fix @at_head kernel-doc warning

Hi Randy,

On 8/16/20 7:25 PM, Randy Dunlap wrote:
> Fix a new kernel-doc warning in block/blk-mq.c:
> 
> ../block/blk-mq.c:1844: warning: Function parameter or member 'at_head' not described in 'blk_mq_request_bypass_insert'
> 
> Fixes: 105663f73e71 ("blk-mq: Document functions for sending request")

By the time commit 105663f73e71 ("blk-mq: Document functions for sending
request") was merged, the parameter @at_head didn't exist[1].

The commit that inserted this warning is 01e99aeca397 ("blk-mq: insert
passthrough request into hctx->dispatch directly"), that added @at_head
without updating the documentation.

Thanks,
	André

[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/block/blk-mq.c?id=105663f73e71b5e79ecf472c0499c9acde654b28#n1673