lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Mon, 17 Aug 2020 07:50:55 +0800
From:   kernel test robot <lkp@...el.com>
To:     Joe Perches <joe@...ches.com>, Jeff Layton <jlayton@...nel.org>,
        Ilya Dryomov <idryomov@...il.com>
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        ceph-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ceph: Use generic debugging facility

Hi Joe,

I love your patch! Yet something to improve:

[auto build test ERROR on ceph-client/for-linus]
[also build test ERROR on v5.9-rc1 next-20200814]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Joe-Perches/ceph-Neaten-debugging/20200817-060623
base:   https://github.com/ceph/ceph-client.git for-linus
config: x86_64-randconfig-a012-20200817 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project ab9fc8bae805c785066779e76e7846aabad5609e)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> net/ceph/ceph_common.c:227:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("parse_fsid '%s'\n", str);
           ^
   net/ceph/ceph_common.c:227:2: note: did you mean 'dput'?
   include/linux/dcache.h:374:13: note: 'dput' declared here
   extern void dput(struct dentry *);
               ^
   net/ceph/ceph_common.c:342:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("destroy_options %p\n", opt);
           ^
   net/ceph/ceph_common.c:430:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s fs_parse '%s' token %d\n", __func__, param->key, token);
           ^
   net/ceph/ceph_common.c:726:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("destroy_client %p\n", client);
           ^
   net/ceph/ceph_common.c:779:3: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
                   dout("mount waiting for mon_map\n");
                   ^
   net/ceph/ceph_common.c:802:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("open_session start\n");
           ^
   net/ceph/ceph_common.c:864:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("exit_ceph_lib\n");
           ^
   7 errors generated.
--
   net/ceph/messenger.c:204:5: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat]
                            ntohs(in4->sin_port));
                            ^~~~~~~~~~~~~~~~~~~~
   include/linux/byteorder/generic.h:142:18: note: expanded from macro 'ntohs'
   #define ntohs(x) ___ntohs(x)
                    ^~~~~~~~~~~
   include/linux/byteorder/generic.h:137:21: note: expanded from macro '___ntohs'
   #define ___ntohs(x) __be16_to_cpu(x)
                       ^~~~~~~~~~~~~~~~
   include/uapi/linux/byteorder/little_endian.h:42:26: note: expanded from macro '__be16_to_cpu'
   #define __be16_to_cpu(x) __swab16((__force __u16)(__be16)(x))
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/uapi/linux/swab.h:105:2: note: expanded from macro '__swab16'
           (__builtin_constant_p((__u16)(x)) ?     \
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   net/ceph/messenger.c:210:5: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat]
                            ntohs(in6->sin6_port));
                            ^~~~~~~~~~~~~~~~~~~~~
   include/linux/byteorder/generic.h:142:18: note: expanded from macro 'ntohs'
   #define ntohs(x) ___ntohs(x)
                    ^~~~~~~~~~~
   include/linux/byteorder/generic.h:137:21: note: expanded from macro '___ntohs'
   #define ___ntohs(x) __be16_to_cpu(x)
                       ^~~~~~~~~~~~~~~~
   include/uapi/linux/byteorder/little_endian.h:42:26: note: expanded from macro '__be16_to_cpu'
   #define __be16_to_cpu(x) __swab16((__force __u16)(__be16)(x))
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/uapi/linux/swab.h:105:2: note: expanded from macro '__swab16'
           (__builtin_constant_p((__u16)(x)) ?     \
           ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> net/ceph/messenger.c:309:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s con %p sock %d -> %d\n", __func__, con, old_state,
           ^
   net/ceph/messenger.c:309:2: note: did you mean 'dput'?
   include/linux/dcache.h:374:13: note: 'dput' declared here
   extern void dput(struct dentry *);
               ^
   net/ceph/messenger.c:320:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s con %p sock %d -> %d\n", __func__, con, old_state,
           ^
   net/ceph/messenger.c:331:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s con %p sock %d -> %d\n", __func__, con, old_state,
           ^
   net/ceph/messenger.c:344:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s con %p sock %d -> %d\n", __func__, con, old_state,
           ^
   net/ceph/messenger.c:358:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s con %p sock %d -> %d\n", __func__, con, old_state,
           ^
   net/ceph/messenger.c:375:3: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
                   dout("%s on %p state = %lu, queueing work\n", __func__,
                   ^
   net/ceph/messenger.c:395:4: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
                           dout("%s %p queueing write work\n", __func__, con);
                           ^
   net/ceph/messenger.c:400:3: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
                   dout("%s %p nothing to write\n", __func__, con);
                   ^
   net/ceph/messenger.c:409:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s %p state = %lu sk_state = %u\n", __func__,
           ^
   net/ceph/messenger.c:477:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("connect %s\n", ceph_pr_addr(&con->peer_addr));
           ^
   net/ceph/messenger.c:597:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("con_close_socket on %p sock %p\n", con, con->sock);
           ^
   net/ceph/messenger.c:639:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("reset_connection %p\n", con);
           ^
   net/ceph/messenger.c:668:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("con_close %p peer %s\n", con, ceph_pr_addr(&con->peer_addr));
           ^
   net/ceph/messenger.c:692:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("con_open %p %s\n", con, ceph_pr_addr(addr));
           ^
   net/ceph/messenger.c:722:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("con_init %p\n", con);
           ^
   net/ceph/messenger.c:1237:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("prepare_write_message_footer %p\n", con);
           ^
   net/ceph/messenger.c:1293:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("prepare_write_message %p seq %lld type %d len %d+%d+%zd\n",
           ^
   net/ceph/messenger.c:1346:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("prepare_write_ack %p %llu -> %llu\n", con,
           ^
   net/ceph/messenger.c:1367:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("prepare_write_seq %p %llu -> %llu\n", con,
           ^
   fatal error: too many errors emitted, stopping now [-ferror-limit=]
   2 warnings and 20 errors generated.
--
>> net/ceph/msgpool.c:20:3: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
                   dout("msgpool_alloc %s failed\n", pool->name);
                   ^
   net/ceph/msgpool.c:20:3: note: did you mean 'dput'?
   include/linux/dcache.h:374:13: note: 'dput' declared here
   extern void dput(struct dentry *);
               ^
   net/ceph/msgpool.c:22:3: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
                   dout("msgpool_alloc %s %p\n", pool->name, msg);
                   ^
   net/ceph/msgpool.c:33:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("msgpool_release %s %p\n", pool->name, msg);
           ^
   net/ceph/msgpool.c:42:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("msgpool %s init\n", name);
           ^
   net/ceph/msgpool.c:55:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("msgpool %s destroy\n", pool->name);
           ^
   net/ceph/msgpool.c:77:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("msgpool_get %s %p\n", pool->name, msg);
           ^
   net/ceph/msgpool.c:83:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("msgpool_put %s %p\n", pool->name, msg);
           ^
   7 errors generated.
--
>> net/ceph/buffer.c:29:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("buffer_new %p\n", b);
           ^
   net/ceph/buffer.c:29:2: note: did you mean 'dput'?
   include/linux/dcache.h:374:13: note: 'dput' declared here
   extern void dput(struct dentry *);
               ^
   net/ceph/buffer.c:38:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("buffer_release %p\n", b);
           ^
   net/ceph/buffer.c:50:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("decode_buffer len %d\n", (int)len);
           ^
   3 errors generated.
--
>> net/ceph/mon_client.c:53:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("monmap_decode %p %p len %d (%d)\n", p, end, len, (int)(end-p));
           ^
   net/ceph/mon_client.c:53:2: note: did you mean 'dput'?
   include/linux/dcache.h:374:13: note: 'dput' declared here
   extern void dput(struct dentry *);
               ^
   net/ceph/mon_client.c:123:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("__close_session closing mon%d\n", monc->cur_mon);
           ^
   net/ceph/mon_client.c:165:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s mon%d -> mon%d out of %d mons\n", __func__, old_mon,
           ^
   net/ceph/mon_client.c:188:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s opening mon%d\n", __func__, monc->cur_mon);
           ^
   net/ceph/mon_client.c:228:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s hunt_mult now %d\n", __func__, monc->hunt_mult);
           ^
   net/ceph/mon_client.c:243:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("__schedule_delayed after %lu\n", delay);
           ^
   net/ceph/mon_client.c:267:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s sent %lu\n", __func__, monc->sub_renew_sent);
           ^
   net/ceph/mon_client.c:327:3: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
                   dout("%s sent %lu duration %d renew after %lu\n", __func__,
                   ^
   net/ceph/mon_client.c:331:3: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
                   dout("%s sent %lu renew after %lu, ignoring\n", __func__,
                   ^
   net/ceph/mon_client.c:353:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s %s epoch %u continuous %d\n", __func__, ceph_sub_str[sub],
           ^
   net/ceph/mon_client.c:389:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s %s epoch %u\n", __func__, ceph_sub_str[sub], epoch);
           ^
   net/ceph/mon_client.c:475:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("handle_monmap\n");
           ^
   net/ceph/mon_client.c:513:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s greq %p request %p reply %p\n", __func__, req, req->request,
           ^
   net/ceph/mon_client.c:550:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s greq %p\n", __func__, req);
           ^
   net/ceph/mon_client.c:570:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s greq %p tid %llu\n", __func__, req, req->tid);
           ^
   net/ceph/mon_client.c:579:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s greq %p tid %llu\n", __func__, req, req->tid);
           ^
   net/ceph/mon_client.c:606:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s greq %p tid %llu\n", __func__, req, req->tid);
           ^
   net/ceph/mon_client.c:623:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s greq %p tid %llu\n", __func__, req, req->tid);
           ^
   net/ceph/mon_client.c:645:3: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
                   dout("get_generic_reply %lld dne\n", tid);
                   ^
   fatal error: too many errors emitted, stopping now [-ferror-limit=]
   20 errors generated.
--
>> net/ceph/cls_lock_client.c:71:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s lock_name %s type %d cookie %s tag %s desc %s flags 0x%x\n",
           ^
   net/ceph/cls_lock_client.c:71:2: note: did you mean 'dput'?
   include/linux/dcache.h:374:13: note: 'dput' declared here
   extern void dput(struct dentry *);
               ^
   net/ceph/cls_lock_client.c:120:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s lock_name %s cookie %s\n", __func__, lock_name, cookie);
           ^
   net/ceph/cls_lock_client.c:172:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s lock_name %s cookie %s locker %s%llu\n", __func__, lock_name,
           ^
   net/ceph/cls_lock_client.c:223:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s lock_name %s type %d old_cookie %s tag %s new_cookie %s\n",
           ^
   net/ceph/cls_lock_client.c:276:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s %s%llu cookie %s addr %s\n", __func__,
           ^
   net/ceph/cls_lock_client.c:364:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s lock_name %s\n", __func__, lock_name);
           ^
   6 errors generated.
--
>> net/ceph/osd_client.c:115:3: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
                   dout(" skipping last %llu, final file extent %llu~%llu\n",
                   ^
   net/ceph/osd_client.c:115:3: note: did you mean 'dput'?
   include/linux/dcache.h:374:13: note: 'dput' declared here
   extern void dput(struct dentry *);
               ^
   net/ceph/osd_client.c:119:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("calc_layout objnum=%llx %llu~%llu\n", *objnum, *objoff, *objlen);
           ^
   net/ceph/osd_client.c:485:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s %p (r_request %p r_reply %p)\n", __func__, req,
           ^
   net/ceph/osd_client.c:510:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s %p (was %d)\n", __func__, req,
           ^
   net/ceph/osd_client.c:519:3: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
                   dout("%s %p (was %d)\n", __func__, req,
                   ^
   net/ceph/osd_client.c:558:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s req %p\n", __func__, req);
           ^
   net/ceph/osd_client.c:604:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s req %p\n", __func__, req);
           ^
   net/ceph/osd_client.c:1249:3: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
                   dout("get_osd %p %d -> %d\n", osd, refcount_read(&osd->o_ref)-1,
                   ^
   net/ceph/osd_client.c:1253:3: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
                   dout("get_osd %p FAIL\n", osd);
                   ^
   net/ceph/osd_client.c:1260:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("put_osd %p %d -> %d\n", osd, refcount_read(&osd->o_ref),
           ^
   net/ceph/osd_client.c:1274:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s osd %p osd%d\n", __func__, osd, osd->o_osd);
           ^
   net/ceph/osd_client.c:1295:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s osd %p osd%d\n", __func__, osd, osd->o_osd);
           ^
   net/ceph/osd_client.c:1313:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s osd %p osd%d\n", __func__, osd, osd->o_osd);
           ^
   net/ceph/osd_client.c:1352:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s osd %p osd%d\n", __func__, osd, osd->o_osd);
           ^
   net/ceph/osd_client.c:1408:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s osdc %p osd%d -> osd %p\n", __func__, osdc, o, osd);
           ^
   net/ceph/osd_client.c:1421:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s osd %p osd%d req %p tid %llu\n", __func__, osd, osd->o_osd,
           ^
   net/ceph/osd_client.c:1438:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s osd %p osd%d req %p tid %llu\n", __func__, osd, osd->o_osd,
           ^
   net/ceph/osd_client.c:1505:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s picked osd%d, primary osd%d\n", __func__,
           ^
   net/ceph/osd_client.c:1535:2: error: implicit declaration of function 'dout' [-Werror,-Wimplicit-function-declaration]
           dout("%s picked osd%d with locality %d, primary osd%d\n", __func__,
           ^
   fatal error: too many errors emitted, stopping now [-ferror-limit=]
   20 errors generated.
..

# https://github.com/0day-ci/linux/commit/ab0413062c34a692c0480a3237a04534f823e02d
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Joe-Perches/ceph-Neaten-debugging/20200817-060623
git checkout ab0413062c34a692c0480a3237a04534f823e02d
vim +/dout +227 net/ceph/ceph_common.c

3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  219  
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  220  static int parse_fsid(const char *str, struct ceph_fsid *fsid)
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  221  {
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  222  	int i = 0;
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  223  	char tmp[3];
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  224  	int err = -EINVAL;
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  225  	int d;
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  226  
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06 @227  	dout("parse_fsid '%s'\n", str);
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  228  	tmp[2] = 0;
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  229  	while (*str && i < 16) {
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  230  		if (ispunct(*str)) {
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  231  			str++;
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  232  			continue;
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  233  		}
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  234  		if (!isxdigit(str[0]) || !isxdigit(str[1]))
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  235  			break;
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  236  		tmp[0] = str[0];
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  237  		tmp[1] = str[1];
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  238  		if (sscanf(tmp, "%x", &d) < 1)
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  239  			break;
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  240  		fsid->fsid[i] = d & 0xff;
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  241  		i++;
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  242  		str += 2;
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  243  	}
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  244  
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  245  	if (i == 16)
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  246  		err = 0;
4c069a5821ddc5 Chengguang Xu 2018-01-30  247  	dout("parse_fsid ret %d got fsid %pU\n", err, fsid);
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  248  	return err;
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  249  }
3d14c5d2b6e15c Yehuda Sadeh  2010-04-06  250  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (33911 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ