linux-kernel - Re: [PATCH] IB/mlx5: Fix memleak in subscribe_event_xa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200816081135.GG7555@unreal>
Date:   Sun, 16 Aug 2020 11:11:35 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Dinghao Liu <dinghao.liu@....edu.cn>
Cc:     kjlu@....edu, Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Yishai Hadas <yishaih@...lanox.com>,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] IB/mlx5: Fix memleak in subscribe_event_xa_alloc

On Sat, Aug 15, 2020 at 11:45:37AM +0800, Dinghao Liu wrote:
> When xa_insert() fails, obj_event needs to be freed
> just like what we have done to event when xa_insert()
> fails. However, current code is returning directly
> and ends up leaking memory.
>
> Fixes: 7597385371425 ("IB/mlx5: Enable subscription for device events over DEVX")
> Signed-off-by: Dinghao Liu <dinghao.liu@....edu.cn>
> ---
>  drivers/infiniband/hw/mlx5/devx.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>

Thanks,
Acked-by: Leon Romanovsky <leonro@...dia.com>