linux-kernel - Re: [PATCH v5 5/5] iio:temperature:mlx90632: Some stylefixing leftovers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200816093817.713a29b3@archlinux>
Date:   Sun, 16 Aug 2020 09:38:17 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Crt Mori <cmo@...exis.com>, linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 5/5] iio:temperature:mlx90632: Some stylefixing
 leftovers

On Thu, 13 Aug 2020 22:41:51 +0300
Andy Shevchenko <andy.shevchenko@...il.com> wrote:

> On Thu, Aug 13, 2020 at 4:12 PM Crt Mori <cmo@...exis.com> wrote:
> > On Thu, 13 Aug 2020 at 13:01, Andy Shevchenko <andy.shevchenko@...il.com> wrote:  
> > > On Thu, Aug 13, 2020 at 10:53 AM Crt Mori <cmo@...exis.com> wrote:  
> 
> ...
> 
> > > > -#define MLX90632_REF_12                12LL /**< ResCtrlRef value of Ch 1 or Ch 2 */
> > > > -#define MLX90632_REF_3         12LL /**< ResCtrlRef value of Channel 3 */
> > > > -#define MLX90632_MAX_MEAS_NUM  31 /**< Maximum measurements in list */
> > > > -#define MLX90632_SLEEP_DELAY_MS 3000 /**< Autosleep delay */  
> 
> > > > +#define MLX90632_REF_12        12LL /* ResCtrlRef value of Ch 1 or Ch 2 */
> > > > +#define MLX90632_REF_3         12LL /* ResCtrlRef value of Channel 3 */
> > > > +#define MLX90632_MAX_MEAS_NUM  31 /* Maximum measurements in list */
> > > > +#define MLX90632_SLEEP_DELAY_MS 3000 /* Autosleep delay */
> > > >  #define MLX90632_EXTENDED_LIMIT 27000 /* Extended mode raw value limit */  
> > >
> > > This was actually in doxy (perhaps kernel doc also understands this)
> > > format of description.
> > > Can you double check that the kernel doc is okay / not okay with it?
> > >
> > > If it is okay, perhaps it's better to convert others to that format
> > > rather than dropping it.
> > >  
> > It is indeed from doxygen and looking at other drivers it should not
> > be OK. I checked the docs and it does not say in fact. Maybe Jonathan
> > knows, but he was already OK with these changes in v1.  
> 
> I'm fine with either choice.
> 
I'd prefer to get rid of them as you have done.  

Jonathan