linux-kernel - Re: [PATCH] tty: serial: fix earlycon dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200817170038.GA725471@kroah.com>
Date:   Mon, 17 Aug 2020 19:00:38 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Tong Zhang <ztong0001@...il.com>
Cc:     jirislaby@...nel.org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tty: serial: fix earlycon dependency

On Mon, Aug 17, 2020 at 12:50:59PM -0400, Tong Zhang wrote:
> parse_options() in drivers/tty/serial/earlycon.c calls
> uart_parse_earlycon() in drivers/tty/serial/serial_core.c
> therefore selecting SERIAL_EARLYCON should automatically
> select SERIAL_CORE, otherwise will result in symbol not
> found error during linking if SERIAL_CORE is not configured
> as builtin

We can handle lines 72 characters long :)

> 
> Signed-off-by: Tong Zhang <ztong0001@...il.com>

What broke to cause this to be needed?

Can you provide a "Fixes:" tag for this?

> ---
>  drivers/tty/serial/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 8a0352eb337c..42e844314cbb 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -8,6 +8,7 @@ menu "Serial drivers"
>  
>  config SERIAL_EARLYCON
>  	bool
> +	select SERIAL_CORE

Are you _sure_ about this?  This feels odd...

thanks,

greg k-h