linux-kernel - Re: [PATCH] power: supply: Add dependency to lego-ev3-battery Kconfig options

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dc296c76-b997-c711-7f60-a7a993601443@lechnology.com>
Date:   Mon, 17 Aug 2020 13:25:45 -0500
From:   David Lechner <david@...hnology.com>
To:     Alex Dewar <alex.dewar90@...il.com>
Cc:     Sebastian Reichel <sre@...nel.org>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Sekhar Nori <nsekhar@...com>,
        Bartosz Go??aszewski <bgolaszewski@...libre.com>
Subject: Re: [PATCH] power: supply: Add dependency to lego-ev3-battery Kconfig
 options

On 8/17/20 12:43 PM, Alex Dewar wrote:
> On Wed, Aug 12, 2020 at 02:12:57PM -0500, David Lechner wrote:
>> On 8/12/20 2:02 PM, Alex Dewar wrote:
>>> On Wed, Aug 12, 2020 at 10:24:30AM -0500, David Lechner wrote:
>>>> On 8/12/20 8:37 AM, Alex Dewar wrote:
>>>>> On Tue, Aug 11, 2020 at 09:24:10AM -0500, David Lechner wrote:
>>>>>> On 8/9/20 1:54 PM, Alex Dewar wrote:
>>>>>>> This battery appears only to be used by a single board (DA850), so it
>>>>>>> makes sense to add this to the Kconfig file so that users don't build
>>>>>>> the module unnecessarily. It currently seems to be built for the x86
>>>>>>> Arch Linux kernel where it's probably not doing much good.
>>>>>>
>>>>>> It would probably also make sense to add "default n" since it only
>>>>>> applies to one board in the entire arch.
>>>>>
>>>>> Ah ok. That makes sense. Would you like me to send a follow-on patch for
>>>>> this?
>>>>
>>>> You can just send a v2 patch that includes the change below and the
>>>> additional change.
>>>
>>> I've just had a look at the documentation[1] and it seems that as there's
>>> no "default y" there it'll default to n anyway. Have I got that right?
>>>
>>> [1] https://www.kernel.org/doc/html/latest/kbuild/kconfig-language.html#menu-attributes
>>>
>>
>> Yes, that seems right. That makes me wonder why this would have been enabled in
>> the Arch Linux kernel for x86 then.
> 
> Not sure, maybe the Arch devs like Lego? ;-)
> 
> Are you happy to give an Acked-by for this anyhoo?

Yup.

Acked-by: David Lechner <david@...hnology.com>

> 
> @Sebastian, are you happy to pick up this patch?
> 
> Best,
> Alex
>