linux-kernel - Re: [RFT v2 02/29] memory: omap-gpmc: Remove unused file-scope phys_base and mem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200817183148.GB3464@kozik-lap>
Date:   Mon, 17 Aug 2020 20:31:48 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
        Markus Mayer <mmayer@...adcom.com>,
        bcm-kernel-feedback-list@...adcom.com,
        Florian Fainelli <f.fainelli@...il.com>,
        Santosh Shilimkar <ssantosh@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Roger Quadros <rogerq@...com>,
        Tony Lindgren <tony@...mide.com>,
        Vladimir Zapolskiy <vz@...ia.com>,
        Kukjin Kim <kgene@...nel.org>,
        Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-omap@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org, linux-tegra@...r.kernel.org
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [RFT v2 02/29] memory: omap-gpmc: Remove unused file-scope
 phys_base and mem_size

On Fri, Jul 24, 2020 at 09:40:11AM +0200, Krzysztof Kozlowski wrote:
> The file-scope variables phys_base and mem_size are assigned in
> gpmc_probe() but never read.
> 
> This fixes build error when compile testing on x86_64 architecture:
> 
>     drivers/memory/omap-gpmc.c:246:24: error: conflicting types for ‘phys_base’
>      static resource_size_t phys_base, mem_size;
>     In file included from arch/x86/include/asm/page.h:12:0,
>                      from arch/x86/include/asm/thread_info.h:12,
>                      from include/linux/thread_info.h:38,
>                      from arch/x86/include/asm/preempt.h:7,
>                      from include/linux/preempt.h:78,
>                      from include/linux/spinlock.h:51,
>                      from include/linux/irq.h:14,
>                      from drivers/memory/omap-gpmc.c:12:
>     arch/x86/include/asm/page_64.h:12:22: note: previous declaration of ‘phys_base’ was here
>      extern unsigned long phys_base;
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  drivers/memory/omap-gpmc.c | 4 ----
>  1 file changed, 4 deletions(-)

Applied to drivers/memory tree.

Best regards,
Krzysztof