linux-kernel - Re: [PATCH -next] ARM: s3c: fix return value check in s3c_usb_otgphy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200817154522.GA15887@kozik-lap>
Date:   Mon, 17 Aug 2020 17:45:22 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Qinglang Miao <miaoqinglang@...wei.com>
Cc:     Kukjin Kim <kgene@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Russell King <linux@...linux.org.uk>,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] ARM: s3c: fix return value check in
 s3c_usb_otgphy_init()

On Tue, Jul 28, 2020 at 10:27:56AM +0800, Qinglang Miao wrote:
> the function clk_get() returns ERR_PTR() in case of error and
> never returns NULL. So there's no need to test whether xusbxti
> is NULL, just remove the redundant part in the return value check.
> 
> Signed-off-by: Qinglang Miao <miaoqinglang@...wei.com>
> ---
>  arch/arm/mach-s3c64xx/setup-usb-phy.c | 2 +-

Thanks, applied.

Best regards,
Krzysztof