linux-kernel - Re: [PATCH] mm: change prev_offset type to unsigned long

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200817151851.GK17456@casper.infradead.org>
Date:   Mon, 17 Aug 2020 16:18:51 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Bean Huo <huobean@...il.com>
Cc:     akpm@...ux-foundation.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Bean Huo <beanhuo@...ron.com>
Subject: Re: [PATCH] mm: change prev_offset type to unsigned long

On Mon, Aug 17, 2020 at 05:06:37PM +0200, Bean Huo wrote:
> From: Bean Huo <beanhuo@...ron.com>

There's no description.  Please explain why this patch is needed.

> Signed-off-by: Bean Huo <beanhuo@...ron.com>
> ---
>  mm/filemap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/filemap.c b/mm/filemap.c
> index cf4bdf7803b6..d736c7a4b826 100644
> --- a/mm/filemap.c
> +++ b/mm/filemap.c
> @@ -2025,7 +2025,7 @@ ssize_t generic_file_buffered_read(struct kiocb *iocb,
>  	pgoff_t last_index;
>  	pgoff_t prev_index;
>  	unsigned long offset;      /* offset into pagecache page */
> -	unsigned int prev_offset;
> +	unsigned long prev_offset;
>  	int error = 0;
>  
>  	if (unlikely(*ppos >= inode->i_sb->s_maxbytes))
> -- 
> 2.17.1
> 
>