linux-kernel - Re: [PATCH] leds: LP55XX_COMMON needs to depend on LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200817202829.GA14094@amd>
Date:   Mon, 17 Aug 2020 22:28:29 +0200
From:   Pavel Machek <pavel@....cz>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     LKML <linux-kernel@...r.kernel.org>, linux-leds@...r.kernel.org,
        Dan Murphy <dmurphy@...com>, Milo Kim <milo.kim@...com>
Subject: Re: [PATCH] leds: LP55XX_COMMON needs to depend on LEDS_CLASS

Hi!

> From: Randy Dunlap <rdunlap@...radead.org>
> 
> With these kernel configs:
> CONFIG_LEDS_CLASS=m
> # CONFIG_LEDS_CLASS_MULTICOLOR is not set
> CONFIG_LEDS_LP55XX_COMMON=y
> CONFIG_LEDS_LP5521=m
> CONFIG_LEDS_LP5562=m
> 
> leds-lp55xx-common.c has a build error because it is builtin and
> calls an interface that is built as a loadable module (due to
> LEDS_CLASS=m). By making LEDS_LP55XX_COMMON depend on LEDS_CLASS,
> this config combination cannot happen, thus preventing the build error.
> 
> ld: drivers/leds/leds-lp55xx-common.o: in function `lp55xx_register_leds':
> leds-lp55xx-common.c:(.text+0xc5f): undefined reference to `devm_led_classdev_register_ext'
> 
> Fixes: 33b3a561f417 ("leds: support new LP8501 device - another LP55xx common")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Pavel Machek <pavel@....cz>
> Cc: Dan Murphy <dmurphy@...com>
> Cc: Milo Kim <milo.kim@...com>
> Cc: linux-leds@...r.kernel.org
> ---
> The Fixes: tag might be incorrect...  I also considered:
> 92a81562e695 ("leds: lp55xx: Add multicolor framework support to
> lp55xx")

Thanks, makes sense, I'll take this one. I believe the second fixes
tag is correct; not that it matters.

Thanks and best regards,
								Pavel
								
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)