linux-kernel - Re: [net-next iproute2 PATCH v4 1/2] iplink: hsr: add support for creating PRP device similar to HSR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <682a636a-a42b-f40d-853c-3ae7d3c4bd82@ti.com>
Date:   Mon, 17 Aug 2020 16:58:39 -0400
From:   Murali Karicheri <m-karicheri2@...com>
To:     Stephen Hemminger <stephen@...workplumber.org>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-api@...r.kernel.org>,
        <nsekhar@...com>, <vinicius.gomes@...el.com>,
        <kuznet@....inr.ac.ru>
Subject: Re: [net-next iproute2 PATCH v4 1/2] iplink: hsr: add support for
 creating PRP device similar to HSR



On 8/16/20 6:46 PM, Stephen Hemminger wrote:
> On Thu, 6 Aug 2020 16:37:11 -0400
> Murali Karicheri <m-karicheri2@...com> wrote:
> 
>> +	
> 
>> +		print_int(PRINT_ANY,
>> +			  "proto",
>> +			  "proto %d ",
>> +			  rta_getattr_u8(tb[IFLA_HSR_PROTOCOL]));
> 
> Since this unsigned value, you probably want to use print_uint, or print_hhu.
> Also please put as many arguments on one line that will fit in 80 (to 90) characters.
> 
> 	if (tb[IFLA_HSR_PROTOCOL])
> 		print_hhu(PRINT_ANY, "proto", "proto %hhu ",
> 			  rta_getattr_u8(tb[IFLA_HSR_PROTOCOL]));
> 
Ok. Will send v5 shortly for this.
-- 
Murali Karicheri
Texas Instruments