linux-kernel - [PATCH] block: fix boolconv.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200817075559.GA149398@7edacc24721b>
Date:   Mon, 17 Aug 2020 15:55:59 +0800
From:   kernel test robot <lkp@...el.com>
To:     Baolin Wang <baolin.wang@...ux.alibaba.com>, axboe@...nel.dk
Cc:     kbuild-all@...ts.01.org, ming.lei@...hat.com, hch@....de,
        baolin.wang@...ux.alibaba.com, baolin.wang7@...il.com,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] block: fix boolconv.cocci warnings

From: kernel test robot <lkp@...el.com>

block/blk-mq-sched.c:404:39-44: WARNING: conversion to bool not needed here

 Remove unneeded conversion to bool

Semantic patch information:
 Relational and logical operators evaluate to bool,
 explicit conversion is overly verbose and unneeded.

Generated by: scripts/coccinelle/misc/boolconv.cocci

CC: Baolin Wang <baolin.wang@...ux.alibaba.com>
Signed-off-by: kernel test robot <lkp@...el.com>
---

url:    https://github.com/0day-ci/linux/commits/Baolin-Wang/Some-clean-ups-for-bio-merge/20200817-121114
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next

Please take the patch only if it's a positive warning. Thanks!

 blk-mq-sched.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/block/blk-mq-sched.c
+++ b/block/blk-mq-sched.c
@@ -401,7 +401,7 @@ bool blk_mq_bio_list_merge(struct reques
 		if (merge == BIO_MERGE_NONE)
 			continue;
 
-		return merge == BIO_MERGE_OK ? true: false;
+		return merge == BIO_MERGE_OK;
 	}
 
 	return false;