lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 16 Aug 2020 22:17:14 -0400
From:   Joel Fernandes <>
Cc:, Aaron Lu <>,
        Aubrey Li <>,
        Julien Desfossez <>,
        Kees Cook <>,
        "Paul E. McKenney" <>,
        Paul Turner <>,
        Steven Rostedt <>,
        Thomas Gleixner <>,
        Tim Chen <>,
        Tim Chen <>,
        Vincent Guittot <>,
        Vineeth Pillai <>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <>,,,
        Phil Auld <>,
        Valentin Schneider <>,
        Paolo Bonzini <>,
        Chen Yu <>,
        Christian Brauner <>
Subject: Re: [PATCH RFC 02/12] entry/idle: Add a common function for
 activites during idle entry/exit

Hello Peter,

On Sat, Aug 15, 2020 at 10:14:41AM +0200, wrote:
> On Fri, Aug 14, 2020 at 11:18:58PM -0400, Joel Fernandes (Google) wrote:
> > Currently only RCU hooks for idle entry/exit are called. In later
> > patches, kernel-entry protection functionality will be added.
> > 
> > Signed-off-by: Joel Fernandes (Google) <>
> NAK, rcu_idle_enter() is broken where it is now, it needs to be pushed
> in deeper:

Thank you for pointing it out. Not a huge problem, a couple ways I can do it:
1. Move the calls to sched_core_unsafe_{enter,exit}() deeper into the idle loop.
2. Keep the calls to sched_core_unsafe_{enter,exit}() where they are now as
   in this patch, but leave out the rcu_idle_{enter,exit}() calls alone so
   they can be moved deeper as you mentioned.

#1 is not necessary for these patches to work and might be overkill.

I'll go the #2 route then. Let me know any other ideas you might have.

What I am trying to do here is to handle a case where task is switching to
idle (say it went to sleep) and wakes up later.

usermode -> syscall (kernel mode - so mark unsafe) -> idle (mark safe).

idle -> syscall wakes (kernel mode - so mark unsafe) -> usermode (mark safe).

Thank you,

 - Joel

Powered by blists - more mailing lists