linux-kernel - Re: [PATCH v3 0/2] add regmap-spi-avmm & Intel Max10 BMC chip support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200817082410.GB19661@yilunxu-OptiPlex-7050>
Date:   Mon, 17 Aug 2020 16:24:10 +0800
From:   Xu Yilun <yilun.xu@...el.com>
To:     broonie@...nel.org, lee.jones@...aro.org,
        linux-kernel@...r.kernel.org
Cc:     trix@...hat.com, matthew.gerlach@...ux.intel.com,
        russell.h.weight@...el.com, lgoncalv@...hat.com, hao.wu@...el.com
Subject: Re: [PATCH v3 0/2] add regmap-spi-avmm & Intel Max10 BMC chip support

Hi Brown & jones:

I tried to refacor the regmap code and add comments in this patchset. I
made big changes to the rx flow and remove some tricky parts in it.

Would it be more understandable than last version? I'm expecting your
comments on it when you have time, thanks in advance.

Yilun

On Wed, Aug 05, 2020 at 04:00:54PM +0800, Xu Yilun wrote:
> This patchset adds the regmap-spi-avmm to support the Intel SPI Slave to
> AVMM Bus Bridge (spi-avmm) IP block. It also implements the usercase - the
> driver of Intel Max10 BMC chip which integrates this IP block.
> 
> Patch #1 implements the regmap-spi-avmm.
> Patch #2 implements the mfd driver of Intel Max10 BMC chip.
> 
> Main changes from v1:
> - Split out the regmap-spi-avmm module out of intel-m10-bmc module.
> 
> Main changes from v2:
> - Refactor the code of regmap-spi-avmm.
>    - Rewrites the rx flow and simplifies the implementation, collapse some
>      function calls.
>    - Add bounds checking every time we fill trans_buf & phy_buf.
>    - Try to configure spi mode on regmap init
>    - delete regmap_bus.reg_write/reg_read callbacks.
>    - Squash the bug fixing patch.
> - Add the sub devices in mfd_cell for Max10 bmc driver.
> - Improve comments and some minor fixes.
> 
> Xu Yilun (2):
>   regmap: add Intel SPI Slave to AVMM Bus Bridge support
>   mfd: intel-m10-bmc: add Max10 BMC chip support for Intel FPGA PAC
> 
>  .../ABI/testing/sysfs-driver-intel-m10-bmc         |  15 +
>  drivers/base/regmap/Kconfig                        |   6 +-
>  drivers/base/regmap/Makefile                       |   1 +
>  drivers/base/regmap/regmap-spi-avmm.c              | 735 +++++++++++++++++++++
>  drivers/mfd/Kconfig                                |  13 +
>  drivers/mfd/Makefile                               |   2 +
>  drivers/mfd/intel-m10-bmc.c                        | 169 +++++
>  include/linux/mfd/intel-m10-bmc.h                  |  57 ++
>  include/linux/regmap.h                             |  36 +
>  9 files changed, 1033 insertions(+), 1 deletion(-)
>  create mode 100644 Documentation/ABI/testing/sysfs-driver-intel-m10-bmc
>  create mode 100644 drivers/base/regmap/regmap-spi-avmm.c
>  create mode 100644 drivers/mfd/intel-m10-bmc.c
>  create mode 100644 include/linux/mfd/intel-m10-bmc.h
> 
> -- 
> 2.7.4