linux-kernel - Re: [PATCH] mm/page_reporting: the "page" must not be the list head

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fa97519b-a860-5fea-9511-2237f195caeb@redhat.com>
Date:   Mon, 17 Aug 2020 11:35:29 +0200
From:   David Hildenbrand <david@...hat.com>
To:     Wei Yang <richard.weiyang@...ux.alibaba.com>,
        alexander.h.duyck@...ux.intel.com, akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/page_reporting: the "page" must not be the list head

On 17.08.20 10:48, Wei Yang wrote:
> If "page" is the list head, list_for_each_entry_safe() would stop
> iteration.
> 
> Signed-off-by: Wei Yang <richard.weiyang@...ux.alibaba.com>
> ---
>  mm/page_reporting.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mm/page_reporting.c b/mm/page_reporting.c
> index 3bbd471cfc81..aaaa3605123d 100644
> --- a/mm/page_reporting.c
> +++ b/mm/page_reporting.c
> @@ -178,7 +178,7 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone,
>  		 * the new head of the free list before we release the
>  		 * zone lock.
>  		 */
> -		if (&page->lru != list && !list_is_first(&page->lru, list))
> +		if (!list_is_first(&page->lru, list))
>  			list_rotate_to_front(&page->lru, list);
>  
>  		/* release lock before waiting on report processing */
> 

Is this a fix or a cleanup? If it's a fix, can this be reproduced easily
and what ere the effects?

-- 
Thanks,

David / dhildenb