linux-kernel - Re: [PATCH RESEND 2/5] block: Remove redundant blk_mq_sched_allow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200817120654.GA79836@VM20190228-100.tbsite.net>
Date:   Mon, 17 Aug 2020 20:06:54 +0800
From:   Baolin Wang <baolin.wang@...ux.alibaba.com>
To:     Christoph Hellwig <hch@....de>
Cc:     axboe@...nel.dk, ming.lei@...hat.com, baolin.wang7@...il.com,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND 2/5] block: Remove redundant
 blk_mq_sched_allow_merge() validation

On Mon, Aug 17, 2020 at 08:22:24AM +0200, Christoph Hellwig wrote:
> On Mon, Aug 17, 2020 at 12:09:16PM +0800, Baolin Wang wrote:
> > Only software queue and kyber IO scheduler will call blk_mq_bio_list_merge()
> > to merge a bio, and kyber IO scheduler did not implement the ops->allow_merge().
> 
> Please line wrap your changelogs after 73 characters.

Sure.

> 
> > Thus we can remove the redundant blk_mq_sched_allow_merge() in
> > blk_mq_bio_list_merge() function.
> 
> This seems potentially dangerous, and I don't think it really buys
> us much.

OK. I can remove this in next version.