linux-kernel - RE: [PATCH 0/3] ASoC: da7219: Reorganise device/codec level probe/remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MW3PR11MB4665D9AD35EF41A7F24F5208855C0@MW3PR11MB4665.namprd11.prod.outlook.com>
Date:   Tue, 18 Aug 2020 16:38:53 +0000
From:   "Zhi, Yong" <yong.zhi@...el.com>
To:     Adam Thomson <Adam.Thomson.Opensource@...semi.com>,
        Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>
CC:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Support Opensource" <support.opensource@...semi.com>
Subject: RE: [PATCH 0/3] ASoC: da7219: Reorganise device/codec level
 probe/remove

Hi, Adam,

> -----Original Message-----
> From: Adam Thomson <Adam.Thomson.Opensource@...semi.com>
> Sent: Tuesday, August 11, 2020 11:57 AM
> To: Mark Brown <broonie@...nel.org>; Takashi Iwai <tiwai@...e.com>; Liam
> Girdwood <lgirdwood@...il.com>; Jaroslav Kysela <perex@...ex.cz>
> Cc: Zhi, Yong <yong.zhi@...el.com>; Pierre-Louis Bossart <pierre-
> louis.bossart@...ux.intel.com>; alsa-devel@...a-project.org; linux-
> kernel@...r.kernel.org; Support Opensource
> <support.opensource@...semi.com>
> Subject: [PATCH 0/3] ASoC: da7219: Reorganise device/codec level
> probe/remove
> 
> This patch set reorganises and fixes device and codec level probe/remove
> handling within the driver, to allow clean probe and remove at the codec level.
> 
> This set relates to an issue raised by Yong Zhi where a codec level re-probe
> would fail due to clks still being registered from the previous instantiation.
> In addition some improvements around regulator handling and soft reset have
> also been included.
> 

Just to let you know that I tested this series on the JSL platform, the original issue was resolved, also sanity checked basic use case like plug/unplug and
suspend/resume, no regression found.

thanks,
yong
> Adam Thomson (3):
>   ASoC: da7219: Move required devm_* allocations to device level code
>   ASoC: da7219: Move soft reset handling to codec level probe
>   ASoC: da7219: Fix clock handling around codec level probe
> 
>  sound/soc/codecs/da7219-aad.c |  85 +++++---
>  sound/soc/codecs/da7219-aad.h |   3 +
>  sound/soc/codecs/da7219.c     | 493 +++++++++++++++++++++++-----------------
> --
>  sound/soc/codecs/da7219.h     |   1 +
>  4 files changed, 328 insertions(+), 254 deletions(-)
> 
> --
> 1.9.1