linux-kernel - Re: [PATCH] clang-format: Fix: Maximum line length is now 100

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 18 Aug 2020 17:53:59 +0100
From:   Alex Dewar <alex.dewar90@...il.com>
To:     Joe Perches <joe@...ches.com>
Cc:     Alex Dewar <alex.dewar90@...il.com>,
        Miguel Ojeda <miguel.ojeda.sandonis@...il.com>,
        linux-kernel@...r.kernel.org, clang-built-linux@...glegroups.com
Subject: Re: [PATCH] clang-format: Fix: Maximum line length is now 100

On Tue, Aug 18, 2020 at 09:52:20AM -0700, Joe Perches wrote:
> On Tue, 2020-08-18 at 17:24 +0100, Alex Dewar wrote:
> > Since commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column
> > warning") the kernel style is now for lines to be a maximum of 100 rather
> > than 80 columns. Update .clang-format accordingly.
> []
> > diff --git a/.clang-format b/.clang-format
> []
> > @@ -52,7 +52,7 @@ BreakConstructorInitializersBeforeComma: false
> >  #BreakConstructorInitializers: BeforeComma # Unknown to clang-format-4.0
> >  BreakAfterJavaFieldAnnotations: false
> >  BreakStringLiterals: false
> > -ColumnLimit: 80
> > +ColumnLimit: 100
> 
> No thank you.
> 
> 100 is used for exceptional line length, not
> for reformatting all lines up to 100 chars.
> 
> See the previous discussion about the same patch
> submitted earlier in June:
> 
> https://lore.kernel.org/lkml/20200610125147.2782142-1-christian.brauner@ubuntu.com/
> 
> 

Ahh, my mistake. Thanks for getting back to me anyhoo.

Alex