linux-kernel - Re: [PATCH] HID: google: add google vivaldi HID driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b1fcca69-8563-0a85-80e0-a955fe8bca6f@infradead.org>
Date:   Mon, 17 Aug 2020 20:28:55 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Sean O'Brien <seobrien@...omium.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Jiri Kosina <jikos@...nel.org>
Cc:     linux-input@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HID: google: add google vivaldi HID driver

On 8/17/20 7:49 PM, Sean O'Brien wrote:
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 05315b434276..5676d4f521c9 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -397,6 +397,15 @@ config HID_GOOGLE_HAMMER
>  	help
>  	Say Y here if you have a Google Hammer device.
>  
> +config HID_GOOGLE_VIVALDI
> +	tristate "Google Vivaldi Keyboard"
> +	depends on HID
> +	help
> +	Say Y here if you want to enable support for Google vivaldi keyboards.

	                                                    Vivaldi
please.

> +
> +	These are keyboards which report physical the order of consumer/action

That's an awkward sentence.  -EPARSE

> +	keys in the top row.
> +

help text lines (those under help) should be indented with one tab + 2 spaces
according to Documentation/process/coding-style.rst.

>  config HID_GT683R
>  	tristate "MSI GT68xR LED support"
>  	depends on LEDS_CLASS && USB_HID


-- 
~Randy