linux-kernel - Re: [PATCH] net/bluetooth/hci_sock.c: add CAP_NET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200818112605.0000735f@intel.com>
Date:   Tue, 18 Aug 2020 11:26:05 -0700
From:   Jesse Brandeburg <jesse.brandeburg@...el.com>
To:     Qingyu Li <ieatmuttonchuan@...il.com>
Cc:     <marcel@...tmann.org>, <johan.hedberg@...il.com>,
        <davem@...emloft.net>, <kuba@...nel.org>,
        <linux-bluetooth@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net/bluetooth/hci_sock.c: add CAP_NET_RAW check.

On Tue, 18 Aug 2020 15:56:48 +0800
Qingyu Li <ieatmuttonchuan@...il.com> wrote:

> When creating a raw PF_BLUETOOTH socket,
> CAP_NET_RAW needs to be checked first.
> 

Thanks for the patch! Your subject doesn't need to end in a period. In
your commit message, I can guess why you'd want this patch, but your
commit message should include more info about why the kernel wants this
patch included. Especially since this is a user visible change and
likely a fix of a bug. Please review:
https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html
specifically:
https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html#q-any-other-tips-to-help-ensure-my-net-net-next-patch-gets-ok-d

This looks like a fix, please add a Fixes tag.