linux-kernel - Re: [PATCH] ACPI/IORT: Drop the unused @ops of iort_add_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b15f022-8fb9-aa5c-fcd8-f92d4878a0a3@huawei.com>
Date:   Tue, 18 Aug 2020 11:49:52 +0800
From:   Hanjun Guo <guohanjun@...wei.com>
To:     Zenghui Yu <yuzenghui@...wei.com>, <lorenzo.pieralisi@....com>,
        <sudeep.holla@....com>
CC:     <linux-acpi@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <wanghaibin.wang@...wei.com>
Subject: Re: [PATCH] ACPI/IORT: Drop the unused @ops of
 iort_add_device_replay()

On 2020/8/17 18:59, Zenghui Yu wrote:
> Since commit d2e1a003af56 ("ACPI/IORT: Don't call iommu_ops->add_device
> directly"), we use the IOMMU core API to replace a direct invoke of the
> specified callback. The parameter @ops has therefore became unused. Let's
> drop it.
> 
> Signed-off-by: Zenghui Yu <yuzenghui@...wei.com>
> ---
>   drivers/acpi/arm64/iort.c | 8 +++-----
>   1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index ec782e4a0fe4..a0ece0e201b2 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -811,8 +811,7 @@ static inline const struct iommu_ops *iort_fwspec_iommu_ops(struct device *dev)
>   	return (fwspec && fwspec->ops) ? fwspec->ops : NULL;
>   }
>   
> -static inline int iort_add_device_replay(const struct iommu_ops *ops,
> -					 struct device *dev)
> +static inline int iort_add_device_replay(struct device *dev)
>   {
>   	int err = 0;
>   
> @@ -1072,7 +1071,7 @@ const struct iommu_ops *iort_iommu_configure_id(struct device *dev,
>   	 */
>   	if (!err) {
>   		ops = iort_fwspec_iommu_ops(dev);
> -		err = iort_add_device_replay(ops, dev);
> +		err = iort_add_device_replay(dev);
>   	}
>   
>   	/* Ignore all other errors apart from EPROBE_DEFER */
> @@ -1089,8 +1088,7 @@ const struct iommu_ops *iort_iommu_configure_id(struct device *dev,
>   #else
>   static inline const struct iommu_ops *iort_fwspec_iommu_ops(struct device *dev)
>   { return NULL; }
> -static inline int iort_add_device_replay(const struct iommu_ops *ops,
> -					 struct device *dev)
> +static inline int iort_add_device_replay(struct device *dev)

inline functions iort_fwspec_iommu_ops() and iort_add_device_replay()
are not needed anymore after commit 8212688600ed ("ACPI/IORT: Fix build
error when IOMMU_SUPPORT is disabled"), could you please add another
patch to remove them as well?

Thanks
Hanjun