linux-kernel - Re: [PATCH v6 09/10] net: eth: altera: add msgdma prefetcher

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200818115857.78d6b2ac@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Tue, 18 Aug 2020 11:58:57 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     "Ooi, Joyce" <joyce.ooi@...el.com>
Cc:     "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Dalon Westergreen <dalon.westergreen@...ux.intel.com>,
        Tan Ley Foon <ley.foon.tan@...el.com>,
        See Chin Liang <chin.liang.see@...el.com>,
        Dinh Nguyen <dinh.nguyen@...el.com>,
        Dalon Westergreen <dalon.westergreen@...el.com>
Subject: Re: [PATCH v6 09/10] net: eth: altera: add msgdma prefetcher

On Tue, 18 Aug 2020 23:46:12 +0800 Ooi, Joyce wrote:
> From: Dalon Westergreen <dalon.westergreen@...el.com>
> 
> Add support for the mSGDMA prefetcher.  The prefetcher adds support
> for a linked list of descriptors in system memory.  The prefetcher
> feeds these to the mSGDMA dispatcher.

This generates warnings on 32bit builds:

../drivers/net/ethernet/altera/altera_msgdma_prefetcher.c: In function ‘msgdma_pref_initialize’:
../drivers/net/ethernet/altera/altera_msgdma_prefetcher.c:97:51: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 4 has type ‘dma_addr_t’ {aka ‘unsigned int’} [-Wformat=]
   97 |   netdev_info(priv->dev, "%s: RX Desc mem at 0x%llx\n", __func__,
      |                                                ~~~^
      |                                                   |
      |                                                   long long unsigned int
      |                                                %x
   98 |        priv->pref_rxdescphys);
      |        ~~~~~~~~~~~~~~~~~~~~~                       
      |            |
      |            dma_addr_t {aka unsigned int}
../drivers/net/ethernet/altera/altera_msgdma_prefetcher.c:101:51: warning: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 4 has type ‘dma_addr_t’ {aka ‘unsigned int’} [-Wformat=]
  101 |   netdev_info(priv->dev, "%s: TX Desc mem at 0x%llx\n", __func__,
      |                                                ~~~^
      |                                                   |
      |                                                   long long unsigned int
      |                                                %x
  102 |        priv->pref_txdescphys);
      |        ~~~~~~~~~~~~~~~~~~~~~                       
      |            |
      |            dma_addr_t {aka unsigned int}