linux-kernel - Re: [PATCH] rpl_iptunnel: simplify the return expression of rpl_do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200818.123550.1614770957816770142.davem@davemloft.net>
Date:   Tue, 18 Aug 2020 12:35:50 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     vulab@...as.ac.cn
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org, kuba@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rpl_iptunnel: simplify the return expression of
 rpl_do_srh()

From: Xu Wang <vulab@...as.ac.cn>
Date: Tue, 18 Aug 2020 08:54:54 +0000

> @@ -197,11 +197,7 @@ static int rpl_do_srh(struct sk_buff *skb, const struct rpl_lwt *rlwt)
>  
>  	tinfo = rpl_encap_lwtunnel(dst->lwtstate);
>  
> -	err = rpl_do_srh_inline(skb, rlwt, tinfo->srh);
> -	if (err)
> -		return err;
> -
> -	return 0;
> +	return rpl_do_srh_inline(skb, rlwt, tinfo->srh);
>  }

Please at least compile test your changes:

net/ipv6/rpl_iptunnel.c: In function ‘rpl_do_srh’:
net/ipv6/rpl_iptunnel.c:193:6: warning: unused variable ‘err’ [-Wunused-variable]
  193 |  int err = 0;