linux-kernel - Re: [PATCH] net: gianfar: Add of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200818.131344.848165078661661080.davem@davemloft.net>
Date:   Tue, 18 Aug 2020 13:13:44 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     sylphrenadin@...il.com
Cc:     claudiu.manoil@....com, kuba@...nel.org, Julia.Lawall@...6.fr,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: gianfar: Add of_node_put() before goto statement

From: Sumera Priyadarsini <sylphrenadin@...il.com>
Date: Wed, 19 Aug 2020 00:22:41 +0530

> Every iteration of for_each_available_child_of_node() decrements
> reference count of the previous node, however when control
> is transferred from the middle of the loop, as in the case of
> a return or break or goto, there is no decrement thus ultimately
> resulting in a memory leak.
> 
> Fix a potential memory leak in gianfar.c by inserting of_node_put()
> before the goto statement.
> 
> Issue found with Coccinelle.
> 
> Signed-off-by: Sumera Priyadarsini <sylphrenadin@...il.com>

These OF iterators are so error prone...

Applied, thanks.