linux-kernel - Re: [PATCH v2] Fixes: tty: serial: earlycon dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <603a20ef-fe09-c4ae-11d0-3f1dc7b87580@kernel.org>
Date:   Tue, 18 Aug 2020 07:42:29 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Tong Zhang <ztong0001@...il.com>, gregkh@...uxfoundation.org,
        linux-serial@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Peter Hurley <peter@...leysoftware.com>
Subject: Re: [PATCH v2] Fixes: tty: serial: earlycon dependency

On 17. 08. 20, 20:54, Tong Zhang wrote:
> parse_options() in drivers/tty/serial/earlycon.c calls uart_parse_earlycon
> in drivers/tty/serial/serial_core.c therefore selecting SERIAL_EARLYCON
> should automatically select SERIAL_CORE, otherwise will result in symbol
> not found error during linking if SERIAL_CORE is not configured as builtin
> 
> Signed-off-by: Tong Zhang <ztong0001@...il.com>

The "Fixes:" keyword should not have been in the Subject but here.
According to your findings something like this:

Fixes: 73abaf87f01b (serial: earlycon: Refactor parse_options into
serial core)

I am not sure:
1) it should be "select" (and not "depends")
2) serial earlycon should depend on serial core. But it's likely OK.

>  drivers/tty/serial/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 8a0352eb337c..42e844314cbb 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -8,6 +8,7 @@ menu "Serial drivers"
>  
>  config SERIAL_EARLYCON
>  	bool
> +	select SERIAL_CORE
>  	help
>  	  Support for early consoles with the earlycon parameter. This enables
>  	  the console before standard serial driver is probed. The console is
> 

thanks,
-- 
js
suse labs