linux-kernel - Re: [PATCH 5.8 214/464] iomap: Make sure iomap_end is called after iomap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Aug 2020 20:55:36 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Andreas Grünbacher 
        <andreas.gruenbacher@...il.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        stable@...r.kernel.org, Andreas Gruenbacher <agruenba@...hat.com>,
        Christoph Hellwig <hch@....de>,
        "Darrick J. Wong" <darrick.wong@...cle.com>
Subject: Re: [PATCH 5.8 214/464] iomap: Make sure iomap_end is called after
 iomap_begin

On Mon, Aug 17, 2020 at 09:56:02PM +0200, Andreas Grünbacher wrote:
>Gerg,
>
>Am Mo., 17. Aug. 2020 um 21:39 Uhr schrieb Greg Kroah-Hartman
><gregkh@...uxfoundation.org>:
>> From: Andreas Gruenbacher <agruenba@...hat.com>
>>
>> [ Upstream commit 856473cd5d17dbbf3055710857c67a4af6d9fcc0 ]
>>
>> Make sure iomap_end is always called when iomap_begin succeeds.
>>
>> Without this fix, iomap_end won't be called when a filesystem's
>> iomap_begin operation returns an invalid mapping, bypassing any
>> unlocking done in iomap_end.  With this fix, the unlocking will still
>> happen.
>>
>> This bug was found by Bob Peterson during code review.  It's unlikely
>> that such iomap_begin bugs will survive to affect users, so backporting
>> this fix seems unnecessary.
>
>this doesn't need to be backported.

Now dropped, thanks!

-- 
Thanks,
Sasha