linux-kernel - RE: [PATCH v1 7/7] dt-bindings: phy: cadence-torrent: Update Torrent PHY bindings for generic use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <DM6PR07MB61546EAD17F3221DEF393780C55C0@DM6PR07MB6154.namprd07.prod.outlook.com>
Date:   Tue, 18 Aug 2020 07:08:27 +0000
From:   Swapnil Kashinath Jakhade <sjakhade@...ence.com>
To:     Rob Herring <robh@...nel.org>
CC:     "kishon@...com" <kishon@...com>, "jsarha@...com" <jsarha@...com>,
        "vkoul@...nel.org" <vkoul@...nel.org>,
        "tomi.valkeinen@...com" <tomi.valkeinen@...com>,
        Yuti Suresh Amonkar <yamonkar@...ence.com>,
        Milind Parab <mparab@...ence.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "nsekhar@...com" <nsekhar@...com>
Subject: RE: [PATCH v1 7/7] dt-bindings: phy: cadence-torrent: Update Torrent
 PHY bindings for generic use

Hi Rob,

> -----Original Message-----
> From: Rob Herring <robh@...nel.org>
> Sent: Wednesday, August 12, 2020 9:57 PM
> To: Swapnil Kashinath Jakhade <sjakhade@...ence.com>
> Cc: kishon@...com; jsarha@...com; vkoul@...nel.org;
> tomi.valkeinen@...com; Yuti Suresh Amonkar <yamonkar@...ence.com>;
> Milind Parab <mparab@...ence.com>; robh+dt@...nel.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; nsekhar@...com
> Subject: Re: [PATCH v1 7/7] dt-bindings: phy: cadence-torrent: Update
> Torrent PHY bindings for generic use
> 
> EXTERNAL MAIL
> 
> 
> On Fri, 07 Aug 2020 12:12:45 +0200, Swapnil Jakhade wrote:
> > Torrent PHY can be used in different multi-link multi-protocol
> > configurations including protocols other than DisplayPort also, such
> > as PCIe, USB, SGMII, QSGMII etc. Update the bindings to have support
> > for these configurations.
> >
> > Signed-off-by: Swapnil Jakhade <sjakhade@...ence.com>
> > ---
> >  .../bindings/phy/phy-cadence-torrent.yaml     | 76 ++++++++++++++-----
> >  1 file changed, 58 insertions(+), 18 deletions(-)
> >
> 
> 
> My bot found errors running 'make dt_binding_check' on your patch:
> 
> Error: Documentation/devicetree/bindings/phy/phy-cadence-
> torrent.example.dts:93.38-39 syntax error FATAL ERROR: Unable to parse
> input tree
> make[1]: *** [scripts/Makefile.lib:330:
> Documentation/devicetree/bindings/phy/phy-cadence-
> torrent.example.dt.yaml] Error 1
> make[1]: *** Waiting for unfinished jobs....
> make: *** [Makefile:1334: dt_binding_check] Error 2
> 
> 
> See
> https://urldefense.com/v3/__https://patchwork.ozlabs.org/patch/1342193_
> _;!!EHscmS1ygiU1lA!SVJ6n249DhrJY-
> i_QSvywciTmAiJRcn9zUnmEeSR5UI4tt9jxEzzj9r5Rz1ZiOY$
> 
> If you already ran 'make dt_binding_check' and didn't see the above error(s),
> then make sure dt-schema is up to date:
> 
> pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --
> upgrade
> 
> Please check and re-submit.

This patch and the series requires the macro definition for PHY_TYPE_SGMII in
file include/dt-bindings/phy/phy.h
This error is because of missing this macro definition. It has been newly added
and present in kernel v5.9-rc1
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/diff/include/dt-bindings/phy/phy.h?id=v5.9-rc1&id2=v5.8
So latest version should not get this error.

Thanks,
Swapnil