linux-kernel - Re: [PATCH 2/2] tasks: Add task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20200818085547.ADC28A4062@b06wcsmtp001.portsmouth.uk.ibm.com>
Date:   Tue, 18 Aug 2020 14:25:46 +0530
From:   Ritesh Harjani <riteshh@...ux.ibm.com>
To:     Jan Kiszka <jan.kiszka@...mens.com>,
        Kieran Bingham <kbingham@...nel.org>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] tasks: Add task_struct addr for lx-ps cmd



On 8/18/20 11:10 AM, Jan Kiszka wrote:
> On 18.08.20 06:04, Ritesh Harjani wrote:
>> task_struct addr in lx-ps cmd seems helpful
>>
>> <e.g. o/p>
>>        TASK          PID    COMM
>> 0xffffffff82c2b8c0   0   swapper/0
>> 0xffff888a0ba20040   1   systemd
>> 0xffff888a0ba24040   2   kthreadd
>> 0xffff888a0ba28040   3   rcu_gp
>>
>> Signed-off-by: Ritesh Harjani <riteshh@...ux.ibm.com>
>> ---
>>   scripts/gdb/linux/tasks.py | 9 +++++----
>>   1 file changed, 5 insertions(+), 4 deletions(-)
>>
>> diff --git a/scripts/gdb/linux/tasks.py b/scripts/gdb/linux/tasks.py
>> index 0301dc1e0138..17ec19e9b5bf 100644
>> --- a/scripts/gdb/linux/tasks.py
>> +++ b/scripts/gdb/linux/tasks.py
>> @@ -73,11 +73,12 @@ class LxPs(gdb.Command):
>>           super(LxPs, self).__init__("lx-ps", gdb.COMMAND_DATA)
>>   
>>       def invoke(self, arg, from_tty):
>> +        gdb.write("{:>10} {:>12} {:>7}\n".format("TASK", "PID", "COMM"))
>>           for task in task_lists():
>> -            gdb.write("{address} {pid} {comm}\n".format(
>> -                address=task,
>> -                pid=task["pid"],
>> -                comm=task["comm"].string()))
>> +            gdb.write("{} {:^5} {}\n".format(
>> +                task.format_string().split()[0],
>> +                task["pid"].format_string(),
>> +                task["comm"].string()))
>>   
>>   
>>   LxPs()
>>
> 
> This patch is confusing me. We already dump the task address. What the
> patch changes is adding a header and some conversions of the values. Can
> you elaborate?

You are right. Sorry for the confusion. I will update the commit msg (in
v2) to reflect that this patch adds the header and formats the spacing.
Without the patch we get it like this:-

0xffffffff82c2b8c0 <init_task> 0 swapper/0
0xffff888a0ba20040 1 systemd
0xffff888a0ba24040 2 kthreadd
0xffff888a0ba28040 3 rcu_gp

-ritesh