linux-kernel - Re: [Patch v2] mm/page_reporting: drop stale list head check in page_reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200818090917.GA34355@L-31X9LVDL-1304.local>
Date:   Tue, 18 Aug 2020 17:09:18 +0800
From:   Wei Yang <richard.weiyang@...ux.alibaba.com>
To:     Wei Yang <richard.weiyang@...ux.alibaba.com>
Cc:     alexander.h.duyck@...ux.intel.com, akpm@...ux-foundation.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org, david@...hat.com
Subject: Re: [Patch v2] mm/page_reporting: drop stale list head check in
 page_reporting_cycle

On Tue, Aug 18, 2020 at 04:44:48PM +0800, Wei Yang wrote:
>list_for_each_entry_safe() guarantees that we will never stumble over
>the list head; "&page->lru != list" will always evaluate to true. Let's
>simplify.

[david@...hat.com: Changelog refine.]

>
>Signed-off-by: Wei Yang <richard.weiyang@...ux.alibaba.com>
>Reviewed-by: David Hildenbrand <david@...hat.com>
>---
> mm/page_reporting.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/mm/page_reporting.c b/mm/page_reporting.c
>index 3bbd471cfc81..aaaa3605123d 100644
>--- a/mm/page_reporting.c
>+++ b/mm/page_reporting.c
>@@ -178,7 +178,7 @@ page_reporting_cycle(struct page_reporting_dev_info *prdev, struct zone *zone,
> 		 * the new head of the free list before we release the
> 		 * zone lock.
> 		 */
>-		if (&page->lru != list && !list_is_first(&page->lru, list))
>+		if (!list_is_first(&page->lru, list))
> 			list_rotate_to_front(&page->lru, list);
> 
> 		/* release lock before waiting on report processing */
>-- 
>2.20.1 (Apple Git-117)

-- 
Wei Yang
Help you, Help me