linux-kernel - Re: [Letux-kernel] [PATCH] omap5: Fix DSI base address and clocks

Open Source and information security mailing list archives

Message-Id: <9081697A-02F9-42EA-9F22-F62381FA1C79@goldelico.com>
Date:   Tue, 18 Aug 2020 11:58:47 +0200
From:   "H. Nikolaus Schaller" <hns@...delico.com>
To:     Tony Lindgren <tony@...mide.com>
Cc:     kernel@...a-handheld.com,
        Discussions about the Letux Kernel 
        <letux-kernel@...nphoenux.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux-OMAP <linux-omap@...r.kernel.org>
Subject: Re: [Letux-kernel] [PATCH] omap5: Fix DSI base address and clocks

> Am 18.08.2020 um 11:51 schrieb David Shah <dave@....me>:
> 
> DSI was not probing due to base address off by 0x1000, and sys_clk
> missing.
> 
> With this patch, the Pyra display works if HDMI is disabled in the
> device tree.

For me it also works if HDMI is not disabled.
So IMHO this comment is misleading.

Otherwise,

Tested-by: H. Nikolaus Schaller <hns@...delico.com>

> 
> Signed-off-by: David Shah <dave@....me>
> ---
> arch/arm/boot/dts/omap5.dtsi | 20 +++++++++++---------
> 1 file changed, 11 insertions(+), 9 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
> index c96e19a15c52..849a2dd9fef7 100644
> --- a/arch/arm/boot/dts/omap5.dtsi
> +++ b/arch/arm/boot/dts/omap5.dtsi
> @@ -388,11 +388,11 @@ rfbi: encoder@0  {
> 					};
> 				};
> 
> -				target-module@...0 {
> +				target-module@...0 {
> 					compatible = "ti,sysc-omap2", "ti,sysc";
> -					reg = <0x5000 0x4>,
> -					      <0x5010 0x4>,
> -					      <0x5014 0x4>;
> +					reg = <0x4000 0x4>,
> +					      <0x4010 0x4>,
> +					      <0x4014 0x4>;
> 					reg-names = "rev", "sysc", "syss";
> 					ti,sysc-sidle = <SYSC_IDLE_FORCE>,
> 							<SYSC_IDLE_NO>,
> @@ -404,7 +404,7 @@ SYSC_OMAP2_SOFTRESET |
> 					ti,syss-mask = <1>;
> 					#address-cells = <1>;
> 					#size-cells = <1>;
> -					ranges = <0 0x5000 0x1000>;
> +					ranges = <0 0x4000 0x1000>;
> 
> 					dsi1: encoder@0 {
> 						compatible = "ti,omap5-dsi";
> @@ -414,8 +414,9 @@ dsi1: encoder@0 {
> 						reg-names = "proto", "phy", "pll";
> 						interrupts = <GIC_SPI 53 IRQ_TYPE_LEVEL_HIGH>;
> 						status = "disabled";
> -						clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>;
> -						clock-names = "fck";
> +						clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>,
> +							 <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 10>;
> +						clock-names = "fck", "sys_clk";
> 					};
> 				};
> 
> @@ -445,8 +446,9 @@ dsi2: encoder@0 {
> 						reg-names = "proto", "phy", "pll";
> 						interrupts = <GIC_SPI 55 IRQ_TYPE_LEVEL_HIGH>;
> 						status = "disabled";
> -						clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>;
> -						clock-names = "fck";
> +						clocks = <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 8>,
> +							 <&dss_clkctrl OMAP5_DSS_CORE_CLKCTRL 10>;
> +						clock-names = "fck", "sys_clk";
> 					};
> 				};
> 
> -- 
> 2.28.0
> 
> _______________________________________________
> https://projects.goldelico.com/p/gta04-kernel/
> Letux-kernel mailing list
> Letux-kernel@...nphoenux.org
> http://lists.goldelico.com/mailman/listinfo.cgi/letux-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives