linux-kernel - Re: [PATCH v6] arm64: dts: qcom: sc7180: Add Display Port dt node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <159771027430.2423498.17739000479526174339@swboyd.mtv.corp.google.com>
Date:   Mon, 17 Aug 2020 17:24:34 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Tanmay Shah <tanmay@...eaurora.org>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        freedreno@...ts.freedesktop.org, seanpaul@...omium.org,
        robdclark@...il.com, daniel@...ll.ch, airlied@...ux.ie,
        aravindh@...eaurora.org, abhinavk@...eaurora.org,
        khsieh@...eaurora.org, Tanmay Shah <tanmay@...eaurora.org>
Subject: Re: [PATCH v6] arm64: dts: qcom: sc7180: Add Display Port dt node

Quoting Tanmay Shah (2020-08-17 15:53:00)
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 31b9217bb5bf..bf2f2bb1aa79 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -2440,6 +2447,71 @@ dsi_phy: dsi-phy@...4400 {
>  
>                                 status = "disabled";
>                         };
> +
> +                       msm_dp: displayport-controller@...0000 {

This should come before dsi-phy and dsi node. It should be sorted by the
address (0xae90000).

> +                               status = "disabled";
> +                               compatible = "qcom,sc7180-dp";
> +
> +                               reg = <0 0x0ae90000 0 0x1400>;
> +
> +                               interrupt-parent = <&mdss>;
> +                               interrupts = <12>;
> +
[...]
>                 };
>  
>                 dispcc: clock-controller@...0000 {
> @@ -2449,8 +2521,8 @@ dispcc: clock-controller@...0000 {
>                                  <&gcc GCC_DISP_GPLL0_CLK_SRC>,
>                                  <&dsi_phy 0>,
>                                  <&dsi_phy 1>,
> -                                <0>,
> -                                <0>;
> +                                <&msm_dp 0>,
> +                                <&msm_dp 1>;

Don't think we should apply this still because the binding will change
when the phy is split out to qmp node. Maybe just leave this part off
for now?