linux-kernel - Re: [PATCH -next] binderfs: make symbol 'binderfs_fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200818111545.aq3iyhugs2luol52@wittgenstein>
Date:   Tue, 18 Aug 2020 13:15:45 +0200
From:   Christian Brauner <christian.brauner@...ntu.com>
To:     Wei Yongjun <weiyongjun1@...wei.com>
Cc:     Hulk Robot <hulkci@...wei.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arve Hjønnevåg <arve@...roid.com>,
        Todd Kjos <tkjos@...roid.com>,
        Martijn Coenen <maco@...roid.com>,
        Joel Fernandes <joel@...lfernandes.org>,
        Christian Brauner <christian@...uner.io>,
        Hridya Valsaraju <hridya@...gle.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] binderfs: make symbol 'binderfs_fs_parameters'
 static

On Tue, Aug 18, 2020 at 07:22:45PM +0800, Wei Yongjun wrote:
> The sparse tool complains as follows:
> 
> drivers/android/binderfs.c:66:32: warning:
>  symbol 'binderfs_fs_parameters' was not declared. Should it be static?
> 
> This variable is not used outside of binderfs.c, so this commit
> marks it static.
> 
> Fixes: 095cf502b31e ("binderfs: port to new mount api")
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---

Thanks!
Acked-by: Christian Brauner <christian.brauner@...ntu.com>