linux-kernel - Re: [PATCH v3] sched/fair: simplfy the work when reweighting entity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200818113454.GS2674@hirez.programming.kicks-ass.net>
Date:   Tue, 18 Aug 2020 13:34:54 +0200
From:   peterz@...radead.org
To:     Vincent Guittot <vincent.guittot@...aro.org>
Cc:     Jiang Biao <benbjiang@...il.com>, Ingo Molnar <mingo@...hat.com>,
        Juri Lelli <juri.lelli@...hat.com>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ben Segall <bsegall@...gle.com>, Mel Gorman <mgorman@...e.de>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Jiang Biao <benbjiang@...cent.com>
Subject: Re: [PATCH v3] sched/fair: simplfy the work when reweighting entity

On Tue, Aug 18, 2020 at 11:07:37AM +0200, Vincent Guittot wrote:
> On Tue, 11 Aug 2020 at 13:32, Jiang Biao <benbjiang@...il.com> wrote:
> >
> > From: Jiang Biao <benbjiang@...cent.com>
> >
> > The code in reweight_entity() can be simplified.
> >
> > For a sched entity on the rq, the entity accounting can be replaced by
> > cfs_rq instantaneous load updates currently called from within the
> > entity accounting.
> >
> > Even though an entity on the rq can't represent a task in
> > reweight_entity() (a task is always dequeued before calling this
> > function) and so the numa task accounting and the rq->cfs_tasks list
> > management of the entity accounting are never called, the redundant
> > cfs_rq->nr_running decrement/increment will be avoided.
> >
> > Signed-off-by: Jiang Biao <benbjiang@...cent.com>
> 
> Minor typo of the subject: s/simplfy/simplify/

I've made it "Simplify" :-)

Thanks guys!