linux-kernel - Re: [PATCH v2 2/7] regulator: push allocation in regulator_ena_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9ba2952d-9399-2e0f-7beb-7e79b91bbb61@gmail.com>
Date:   Tue, 18 Aug 2020 03:25:29 +0300
From:   Dmitry Osipenko <digetx@...il.com>
To:     Michał Mirosław <mirq-linux@...e.qmqm.pl>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Vladimir Zapolskiy <vz@...ia.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/7] regulator: push allocation in
 regulator_ena_gpio_request() out of lock

12.08.2020 04:31, Michał Mirosław пишет:
> Move another allocation out of regulator_list_mutex-protected region, as
> reclaim might want to take the same lock.

Is it possible to simply use the GFP_NOWAIT flag in all patches where
there is no real need to reshuffle the code? And then add a small
clarifying comment to the code about why GFP_NOWAIT is used.