linux-kernel - Re: [PATCH 2/7] media: coda: no need to check return value of debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Aug 2020 15:56:08 +0200
From:   Philipp Zabel <p.zabel@...gutronix.de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-media@...r.kernel.org
Cc:     Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] media: coda: no need to check return value of
 debugfs_create functions

On Tue, 2020-08-18 at 15:36 +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.
>
> Cc: Philipp Zabel <p.zabel@...gutronix.de>
> Cc: Mauro Carvalho Chehab <mchehab@...nel.org>
> Cc: linux-media@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>

Thank you,

Reviewed-by: Philipp Zabel <p.zabel@...gutronix.de>

regards
Philipp

> ---
>  drivers/media/platform/coda/coda-common.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/media/platform/coda/coda-common.c b/drivers/media/platform/coda/coda-common.c
> index 3ab3d976d8ca..9020be29d8f2 100644
> --- a/drivers/media/platform/coda/coda-common.c
> +++ b/drivers/media/platform/coda/coda-common.c
> @@ -1937,9 +1937,6 @@ int coda_alloc_aux_buf(struct coda_dev *dev, struct coda_aux_buf *buf,
>  		buf->blob.size = size;
>  		buf->dentry = debugfs_create_blob(name, 0644, parent,
>  						  &buf->blob);
> -		if (!buf->dentry)
> -			dev_warn(dev->dev,
> -				 "failed to create debugfs entry %s\n", name);
>  	}
>  
>  	return 0;
> @@ -3211,8 +3208,6 @@ static int coda_probe(struct platform_device *pdev)
>  	ida_init(&dev->ida);
>  
>  	dev->debugfs_root = debugfs_create_dir("coda", NULL);
> -	if (!dev->debugfs_root)
> -		dev_warn(&pdev->dev, "failed to create debugfs root\n");
>  
>  	/* allocate auxiliary per-device buffers for the BIT processor */
>  	if (dev->devtype->product == CODA_DX6) {