linux-kernel - Re: [PATCH] net: Relax the npages test against MAX_SKB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANn89iLuh-3OHDmRKKm3N59oHzC15K+k84KD42Ej+3qP_GC57Q@mail.gmail.com>
Date:   Tue, 18 Aug 2020 07:15:35 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     Miaohe Lin <linmiaohe@...wei.com>
Cc:     David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, martin.varghese@...ia.com,
        Florian Westphal <fw@...len.de>,
        Pravin B Shelar <pshelar@....org>,
        Davide Caratti <dcaratti@...hat.com>,
        Steffen Klassert <steffen.klassert@...unet.com>,
        Paolo Abeni <pabeni@...hat.com>, shmulik@...anetworks.com,
        kyk.segfault@...il.com, netdev <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: Relax the npages test against MAX_SKB_FRAGS

On Tue, Aug 18, 2020 at 4:58 AM Miaohe Lin <linmiaohe@...wei.com> wrote:
>
> The npages test against MAX_SKB_FRAGS can be relaxed if we succeed to
> allocate high order pages as the note in comment said.
>
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> ---
>  net/core/skbuff.c | 11 ++++-------
>  1 file changed, 4 insertions(+), 7 deletions(-)
>
> diff --git a/net/core/skbuff.c b/net/core/skbuff.c
> index 2f7dd689bccc..ca432bbfd90b 100644
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -5758,13 +5758,6 @@ struct sk_buff *alloc_skb_with_frags(unsigned long header_len,
>         struct page *page;
>         int i;
>
> -       *errcode = -EMSGSIZE;
> -       /* Note this test could be relaxed, if we succeed to allocate
> -        * high order pages...
> -        */
> -       if (npages > MAX_SKB_FRAGS)
> -               return NULL;
> -
>         *errcode = -ENOBUFS;
>         skb = alloc_skb(header_len, gfp_mask);
>         if (!skb)
> @@ -5775,6 +5768,10 @@ struct sk_buff *alloc_skb_with_frags(unsigned long header_len,
>         for (i = 0; npages > 0; i++) {
>                 int order = max_page_order;
>
> +               if (unlikely(i >= MAX_SKB_FRAGS)) {
> +                       *errcode = -EMSGSIZE;
> +                       goto failure;
> +               }
>                 while (order) {
>                         if (npages >= 1 << order) {
>                                 page = alloc_pages((gfp_mask & ~__GFP_DIRECT_RECLAIM) |
> --
> 2.19.1




We do not want this change.

This interface is used by datagram providers, we do not want to claim
they can safely use skb allocations over 64KB.

Returning -EMSGSIZE should not depend on availability of high-order pages.

The comment was a hint, but we need first a valid user before
considering expanding the interface.