linux-kernel - Re: [PATCH] staging: emxx_udc: Use standard BIT() macro

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 18 Aug 2020 07:29:02 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Alex Dewar <alex.dewar90@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Saiyam Doshi <saiyamdoshi.in@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: emxx_udc: Use standard BIT() macro

On 8/18/20 6:49 AM, Alex Dewar wrote:
> Currently emxx_udc.h defines bit values using local macros. Use the
> standard one instead.
> 
> Also, combine bit values with bitwise-or rather than addition, as
> suggested by Coccinelle.
> 
> Signed-off-by: Alex Dewar <alex.dewar90@...il.com>

Hi,

Does this build?  Just checking.

Looks like it would need this:

#include <linux/bits.h>

since it (indirectly) provides definition of the BIT() macro.

> ---
>  drivers/staging/emxx_udc/emxx_udc.h | 456 +++++++++++++---------------
>  1 file changed, 211 insertions(+), 245 deletions(-)


thanks.
-- 
~Randy