linux-kernel - Re: [PATCH v3] scsi: ufs: Fix possible infinite loop in ufshcd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <159772029325.19587.9193434104087348194.b4-ty@oracle.com>
Date:   Mon, 17 Aug 2020 23:12:32 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     linux-scsi@...r.kernel.org, bvanassche@....org,
        avri.altman@....com, jejb@...ux.ibm.com, alim.akhtar@...sung.com,
        Stanley Chu <stanley.chu@...iatek.com>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        linux-mediatek@...ts.infradead.org, matthias.bgg@...il.com,
        chaotian.jing@...iatek.com, peter.wang@...iatek.com,
        linux-arm-kernel@...ts.infradead.org, cc.chou@...iatek.com,
        kuohong.wang@...iatek.com, andy.teng@...iatek.com,
        asutoshd@...eaurora.org, cang@...eaurora.org, beanhuo@...ron.com,
        linux-kernel@...r.kernel.org, chun-hung.wu@...iatek.com
Subject: Re: [PATCH v3] scsi: ufs: Fix possible infinite loop in ufshcd_hold

On Sun, 9 Aug 2020 13:07:34 +0800, Stanley Chu wrote:

> In ufshcd_suspend(), after clk-gating is suspended and link is set
> as Hibern8 state, ufshcd_hold() is still possibly invoked before
> ufshcd_suspend() returns. For example, MediaTek's suspend vops may
> issue UIC commands which would call ufshcd_hold() during the command
> issuing flow.
> 
> Now if UFSHCD_CAP_HIBERN8_WITH_CLK_GATING capability is enabled,
> then ufshcd_hold() may enter infinite loops because there is no
> clk-ungating work scheduled or pending. In this case, ufshcd_hold()
> shall just bypass, and keep the link as Hibern8 state.

Applied to 5.9/scsi-fixes, thanks!

[1/1] scsi: ufs: Fix possible infinite loop in ufshcd_hold
      https://git.kernel.org/mkp/scsi/c/93b6c5db0602

-- 
Martin K. Petersen	Oracle Linux Engineering