linux-kernel - drivers/net/wireless/mediatek/mt76/mt7615/sdio_mcu.c:78:62: sparse: sparse: Using plain integer as NULL pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 18 Aug 2020 23:29:16 +0800
From:   kernel test robot <lkp@...el.com>
To:     Sean Wang <sean.wang@...iatek.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Felix Fietkau <nbd@....name>,
        Lorenzo Bianconi <lorenzo@...nel.org>
Subject: drivers/net/wireless/mediatek/mt76/mt7615/sdio_mcu.c:78:62: sparse:
 sparse: Using plain integer as NULL pointer

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   06a4ec1d9dc652e17ee3ac2ceb6c7cf6c2b75cdd
commit: a66cbdd6573db8515735d37793c22605432c346d mt76: mt7615: introduce mt7663s support
date:   4 weeks ago
config: nios2-randconfig-s031-20200818 (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.2-183-gaa6ede3b-dirty
        git checkout a66cbdd6573db8515735d37793c22605432c346d
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=nios2 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>


sparse warnings: (new ones prefixed by >>)

>> drivers/net/wireless/mediatek/mt76/mt7615/sdio_mcu.c:78:62: sparse: sparse: Using plain integer as NULL pointer
   drivers/net/wireless/mediatek/mt76/mt7615/sdio_mcu.c:110:62: sparse: sparse: Using plain integer as NULL pointer
--
>> drivers/net/wireless/mediatek/mt76/mt7615/sdio_txrx.c:243:58: sparse: sparse: Using plain integer as NULL pointer
   drivers/net/wireless/mediatek/mt76/mt7615/sdio_txrx.c:270:58: sparse: sparse: Using plain integer as NULL pointer

# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a66cbdd6573db8515735d37793c22605432c346d
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout a66cbdd6573db8515735d37793c22605432c346d
vim +78 drivers/net/wireless/mediatek/mt76/mt7615/sdio_mcu.c

    65	
    66	int mt7663s_driver_own(struct mt7615_dev *dev)
    67	{
    68		struct sdio_func *func = dev->mt76.sdio.func;
    69		struct mt76_phy *mphy = &dev->mt76.phy;
    70		u32 status;
    71		int ret;
    72	
    73		if (!test_and_clear_bit(MT76_STATE_PM, &mphy->state))
    74			goto out;
    75	
    76		sdio_claim_host(func);
    77	
  > 78		sdio_writel(func, WHLPCR_FW_OWN_REQ_CLR, MCR_WHLPCR, 0);
    79	
    80		ret = readx_poll_timeout(mt7663s_read_pcr, dev, status,
    81					 status & WHLPCR_IS_DRIVER_OWN, 2000, 1000000);
    82		if (ret < 0) {
    83			dev_err(dev->mt76.dev, "Cannot get ownership from device");
    84			set_bit(MT76_STATE_PM, &mphy->state);
    85			sdio_release_host(func);
    86	
    87			return ret;
    88		}
    89	
    90		sdio_release_host(func);
    91	
    92	out:
    93		dev->pm.last_activity = jiffies;
    94	
    95		return 0;
    96	}
    97	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (26852 bytes)