linux-kernel - Re: [PATCH] ALSA: usb-audio: Add prevent wakeup from s3 state trig by Lenovo ThinkCentre TI024Gen3 USB-audio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202008200108.OJKwJBqz%lkp@intel.com>
Date:   Thu, 20 Aug 2020 01:21:15 +0800
From:   kernel test robot <lkp@...el.com>
To:     penghao <penghao@...ontech.com>, perex@...ex.cz, tiwai@...e.com
Cc:     kbuild-all@...ts.01.org, clang-built-linux@...glegroups.com,
        alexander@...y.me, dan.carpenter@...cle.com, crwulff@...il.com,
        penghao@...ontech.com, gustavoars@...nel.org,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: usb-audio: Add prevent wakeup from s3 state trig
 by Lenovo ThinkCentre TI024Gen3 USB-audio

Hi penghao,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on sound/for-next]
[also build test ERROR on v5.9-rc1 next-20200819]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/penghao/ALSA-usb-audio-Add-prevent-wakeup-from-s3-state-trig-by-Lenovo-ThinkCentre-TI024Gen3-USB-audio/20200819-200006
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: x86_64-randconfig-a004-20200818 (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project b34b1e38381fa4d1b1d9751a6b5233b68e734cfe)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> sound/usb/card.c:666:28: error: non-ASCII characters are not allowed outside of literals and identifiers
                   device_set_wakeup_enable(＆dev->dev, 0);
                                            ^~
>> sound/usb/card.c:666:31: error: passing 'struct device' to parameter of incompatible type 'struct device *'; take the address with &
                   device_set_wakeup_enable(＆dev->dev, 0);
                                              ^~~~~~~~
                                              &
   include/linux/pm_wakeup.h:159:59: note: passing argument to parameter 'dev' here
   static inline int device_set_wakeup_enable(struct device *dev, bool enable)
                                                             ^
   2 errors generated.

# https://github.com/0day-ci/linux/commit/b49bfa7145277ea86b0487f7fd4e51566477f092
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review penghao/ALSA-usb-audio-Add-prevent-wakeup-from-s3-state-trig-by-Lenovo-ThinkCentre-TI024Gen3-USB-audio/20200819-200006
git checkout b49bfa7145277ea86b0487f7fd4e51566477f092
vim +666 sound/usb/card.c

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (25925 bytes)