linux-kernel - Re: [PATCH v2] ARM: at91: Add GARDENA smart Gateway (Art. 19000) board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200819223530.GA2083518@bogus>
Date:   Wed, 19 Aug 2020 16:35:30 -0600
From:   Rob Herring <robh@...nel.org>
To:     Reto Schneider <code@...o-schneider.ch>
Cc:     Codrin Ciubotariu <codrin.ciubotariu@...rochip.com>,
        Michael Zimmermann <michael.zimmermann@...ndcentrix.net>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        open list <linux-kernel@...r.kernel.org>,
        Kamel Bouhara <kamel.bouhara@...tlin.com>,
        Cristian Birsan <cristian.birsan@...rochip.com>,
        Eugen Hristev <eugen.hristev@...rochip.com>,
        alexandre.belloni@...tlin.com,
        linux-arm-kernel@...ts.infradead.org, Stefan Roese <sr@...x.de>,
        Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Reto Schneider <reto.schneider@...qvarnagroup.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH v2] ARM: at91: Add GARDENA smart Gateway (Art. 19000)
 board

On Wed, 19 Aug 2020 13:25:47 +0200, Reto Schneider wrote:
> From: Reto Schneider <reto.schneider@...qvarnagroup.com>
> 
> This patch adds support for the GARDENA smart Gateway, which is based on
> the Atmel AT91SAM9G25. It is equipped with 128 MiB of DDR2 RAM and
> 256 MiB NAND storage.
> 
> Please note that this gateway is not actually based on a AT91SAM9x5 EK
> board, but is close enough to allow its DT to be used.
> 
> Co-developed-by: Stefan Roese <sr@...x.de>
> Signed-off-by: Stefan Roese <sr@...x.de>
> Co-developed-by: Michael Zimmermann <michael.zimmermann@...ndcentrix.net>
> Signed-off-by: Michael Zimmermann <michael.zimmermann@...ndcentrix.net>
> Signed-off-by: Reto Schneider <reto.schneider@...qvarnagroup.com>
> ---
>  .../devicetree/bindings/arm/atmel-at91.yaml   |   2 +
>  arch/arm/boot/dts/Makefile                    |   1 +
>  .../dts/at91sam9g25-gardena-smart-gateway.dts | 157 ++++++++++++++++++
>  3 files changed, 160 insertions(+)
>  create mode 100644 arch/arm/boot/dts/at91sam9g25-gardena-smart-gateway.dts
> 


My bot found errors running 'make dt_binding_check' on your patch:

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/atmel-at91.yaml: properties:compatible:oneOf:2:items: [{'enum': ['overkiz,kizboxmini-base', 'overkiz,kizboxmini-mb', 'overkiz,kizboxmini-rd', 'overkiz,smartkiz', 'gardena,smart-gateway-at91sam"']}, {'const': 'atmel,at91sam9g25'}, {'const': 'atmel,at91sam9x5'}, {'const': 'atmel,at91sam9'}] is not valid under any of the given schemas (Possible causes of the failure):
	/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/atmel-at91.yaml: properties:compatible:oneOf:2:items: [{'enum': ['overkiz,kizboxmini-base', 'overkiz,kizboxmini-mb', 'overkiz,kizboxmini-rd', 'overkiz,smartkiz', 'gardena,smart-gateway-at91sam"']}, {'const': 'atmel,at91sam9g25'}, {'const': 'atmel,at91sam9x5'}, {'const': 'atmel,at91sam9'}] is not of type 'object'
	/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/atmel-at91.yaml: properties:compatible:oneOf:2:items:0:enum:4: 'gardena,smart-gateway-at91sam"' does not match '^[a-zA-Z0-9,.\\-_ #+/]+$'

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/arm/atmel-at91.yaml: ignoring, error in schema: properties: compatible: oneOf: 2: items
warning: no schema found in file: ./Documentation/devicetree/bindings/arm/atmel-at91.yaml


See https://patchwork.ozlabs.org/patch/1347723

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.