linux-kernel - Re: [PATCH] hv_utils: return error if host timesysnc update is stale

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202008200645.XuWhc5m2%lkp@intel.com>
Date:   Thu, 20 Aug 2020 06:54:16 +0800
From:   kernel test robot <lkp@...el.com>
To:     Vineeth Pillai <viremana@...ux.microsoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>
Cc:     kbuild-all@...ts.01.org,
        Vineeth Pillai <viremana@...ux.microsoft.com>,
        "K . Y . Srinivasan" <kys@...rosoft.com>,
        linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hv_utils: return error if host timesysnc update is stale

Hi Vineeth,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.9-rc1 next-20200819]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Vineeth-Pillai/hv_utils-return-error-if-host-timesysnc-update-is-stale/20200820-014742
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 18445bf405cb331117bc98427b1ba6f12418ad17
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/hv/hv_util.c:293:44: warning: integer overflow in expression of type 'long int' results in '-1295421440' [-Woverflow]
     293 | const u64 HOST_TIMESYNC_DELAY_THRESH = 600 * NSEC_PER_SEC;
         |                                            ^

# https://github.com/0day-ci/linux/commit/89495ac7e3c97f1a96ba77a67b532cdeaddc624c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Vineeth-Pillai/hv_utils-return-error-if-host-timesysnc-update-is-stale/20200820-014742
git checkout 89495ac7e3c97f1a96ba77a67b532cdeaddc624c
vim +293 drivers/hv/hv_util.c

   289	
   290	/*
   291	 * Hard coded threshold for host timesync delay: 600 seconds
   292	 */
 > 293	const u64 HOST_TIMESYNC_DELAY_THRESH = 600 * NSEC_PER_SEC;
   294	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (74719 bytes)