linux-kernel - Re: [PATCH] drm: ast: fix double __iomem sparse warning

Open Source and information security mailing list archives

Message-ID: <71030cba-99dd-5815-8fac-bfd5de6319f8@suse.de>
Date:   Wed, 19 Aug 2020 09:17:33 +0200
From:   Thomas Zimmermann <tzimmermann@...e.de>
To:     Randy Dunlap <rdunlap@...radead.org>,
        LKML <linux-kernel@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        Dave Airlie <airlied@...hat.com>
Subject: Re: [PATCH] drm: ast: fix double __iomem sparse warning

Hi

Am 18.08.20 um 22:28 schrieb Randy Dunlap:
> From: Randy Dunlap <rdunlap@...radead.org>
> 
> sparse complains about having 2 "__iomem" attributes on the same line
> where only one is needed since the first one applies to everything
> up to the ending ';'.
> However, to make it clear(er) that both of these pointers are
> "__iomem", use separate lines for them.
> 
> ../drivers/gpu/drm/ast/ast_cursor.c:256:26: CK: warning: duplicate [noderef]
> ../drivers/gpu/drm/ast/ast_cursor.c:256:26: CK: error: multiple address space given: __iomem & __iomem
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Dave Airlie <airlied@...hat.com>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: dri-devel@...ts.freedesktop.org
> ---
>  drivers/gpu/drm/ast/ast_cursor.c |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks, added to drm-misc-next

Best regards
Thomas

> 
> --- lnx-59-rc1.orig/drivers/gpu/drm/ast/ast_cursor.c
> +++ lnx-59-rc1/drivers/gpu/drm/ast/ast_cursor.c
> @@ -253,7 +253,8 @@ void ast_cursor_show(struct ast_private
>  		     unsigned int offset_x, unsigned int offset_y)
>  {
>  	u8 x_offset, y_offset;
> -	u8 __iomem *dst, __iomem *sig;
> +	u8 __iomem *dst;
> +	u8 __iomem *sig;
>  	u8 jreg;
>  
>  	dst = ast->cursor.vaddr[ast->cursor.next_index];
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

-- 
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer


Download attachment "signature.asc" of type "application/pgp-signature" (517 bytes)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives