linux-kernel - Re: [PATCH 1/3] libnvdimm: Fix memory leaks in of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <fdbd9d2d-2e5d-8190-5d7c-eec5c4cdadbb@huawei.com>
Date:   Wed, 19 Aug 2020 09:07:59 +0800
From:   "Leizhen (ThunderTown)" <thunder.leizhen@...wei.com>
To:     Markus Elfring <Markus.Elfring@....de>, <linux-nvdimm@...ts.01.org>
CC:     <linux-kernel@...r.kernel.org>,
        Dan Williams <dan.j.williams@...el.com>,
        Dave Jiang <dave.jiang@...el.com>,
        Ira Weiny <ira.weiny@...el.com>,
        "Oliver O'Halloran" <oohall@...il.com>,
        Vishal Verma <vishal.l.verma@...el.com>
Subject: Re: [PATCH 1/3] libnvdimm: Fix memory leaks in of_pmem.c



On 8/19/2020 3:00 AM, Markus Elfring wrote:
>> The memory priv->bus_desc.provider_name allocated by kstrdup() should be
>> freed.
> 
> * Would an imperative wording be preferred for the change description?
> 
> * I propose to add the tag “Fixes” to the commit message.
Thanks for your suggestion, I will add it in v2.

Fixes: 49bddc73d15c ("libnvdimm/of_pmem: Provide a unique name for bus provider")


> 
> Regards,
> Markus
> 
>