linux-kernel - Re: [PATCH] add support for battery charging threshold, mute. correctly save ac/dc brightness to hardware registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdWhSTqCikgnF5vvgw5x96QV5MXBDOWnL4gWt+Z-QK0MQ@mail.gmail.com>
Date:   Wed, 19 Aug 2020 10:50:12 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Kenneth Chan <kenneth.t.chan@...il.com>
Cc:     Platform Driver <platform-driver-x86@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Harald Welte <laforge@...monks.org>
Subject: Re: [PATCH] add support for battery charging threshold, mute.
 correctly save ac/dc brightness to hardware registers

On Tue, Aug 18, 2020 at 9:03 PM Kenneth Chan <kenneth.t.chan@...il.com> wrote:
>

Thank you for a patch, but it misses few crucial points:
 - it should have good description as commit message (body of this letter)
 - it should have signature of origin (Signed-off-by tag) that I can
proceed (I see, it's in wrong position, use `git commit -s` to fix
this)
 - it should be split per one logical change in a patch, e.g. 1)
replacing ACPI prints by pr_*() macros, 2) split MODULE_AUTHOR() by
one author per macro call, 3) etc...


> Signed-off-by: Kenneth Chan <kenneth.t.chan@...il.com>



-- 
With Best Regards,
Andy Shevchenko