linux-kernel - Re: [PATCH] usb-serial:cp210x: add support to software flow control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 19 Aug 2020 10:19:31 +0200
From:   Jan Kiszka <jan.kiszka@...mens.com>
To:     china_shenglong <china_shenglong@....com>
Cc:     Greg KH <gregkh@...uxfoundation.org>, johan@...nel.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
        Wang Sheng Long <shenglong.wang.ext@...mens.com>
Subject: Re: [PATCH] usb-serial:cp210x: add support to software flow control

On 30.07.20 10:32, china_shenglong wrote:
> Hi, Greg
> 
> Yeah, It mainly adjusts the code style according to the kernel
> specification,
> and then modifies it according to your previous review comments.
> 
> Thanks,
> 
> BR/ Wang ShengLong
> 
> 
> At 2020-07-30 16:06:39, "Greg KH" <gregkh@...uxfoundation.org> wrote:
>>On Thu, Jul 30, 2020 at 03:59:22PM +0800, Sheng Long Wang wrote:
>>> From: Wang Sheng Long <shenglong.wang.ext@...mens.com>
>>> 
>>> When data is transmitted between two serial ports,
>>> the phenomenon of data loss often occurs. The two kinds
>>> of flow control commonly used in serial communication
>>> are hardware flow control and software flow control.
>>> 
>>> In serial communication, If you only use RX/TX/GND Pins, you
>>> can't do hardware flow. So we often used software flow control
>>> and prevent data loss. The user sets the software flow control
>>> through the application program, and the application program
>>> sets the software flow control mode for the serial port
>>> chip through the driver.
>>> 
>>> For the cp210 serial port chip, its driver lacks the
>>> software flow control setting code, so the user cannot set
>>> the software flow control function through the application
>>> program. This adds the missing software flow control.
>>> 
>>> Signed-off-by: Wang Sheng Long <shenglong.wang.ext@...mens.com>
>>> ---
>>>  drivers/usb/serial/cp210x.c | 118 ++++++++++++++++++++++++++++++++++--
>>>  1 file changed, 113 insertions(+), 5 deletions(-)
>>
>>What changed from the previous version of this patch?  That should be
>>described below the --- line and this is a v2, right?
>>
>>thanks,
>>
>>greg k-h

This no longer applies. Shenglong, could you send a rebased version as v3?
Please also include a changelog after the "---" separator this time.

Thanks,
Jan

-- 
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux